Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with gcc 8.3.0. #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build with gcc 8.3.0. #123

wants to merge 1 commit into from

Conversation

mity
Copy link

@mity mity commented Jan 16, 2020

This fixes #102 (comment) (the issue in the 1st post there.)

func() and std::func() may conflict, depending on what C++ options
or stanadard or whatever the code including the header uses.
@mloskot
Copy link

mloskot commented Jan 19, 2020

This still does not make the whole thing build and run successfully, does it?

@mity
Copy link
Author

mity commented Jan 19, 2020

This still does not make the whole thing build and run successfully, does it?

No, it does not.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

I didn't want to mix that with this PR because maybe they do work on some other platform(s) and disabling them is not really a fix.

@mloskot
Copy link

mloskot commented Jan 19, 2020

This still does not make the whole thing build and run successfully, does it?

No, it does not.

OK. I was double-checking what's the status of the repo.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

Yup, I confirm it's needed (as per detailed in comments to #102).

Thanks.

@mity
Copy link
Author

mity commented Jan 19, 2020

If you find it useful, https://github.com/mity/nativejson-benchmark (master) now contains all the fixes (and addition of Centijson) I needed to make it work on my machine.

Don't be fooled though: I use it now for checking my JSON implementation but I have no intention to maintain the benchmark in the long term.

@mloskot
Copy link

mloskot commented Jan 19, 2020

@mity Thanks. I did similar and have fixed branch in my fork :) Not to be maintained in long term either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on Linux (both x64 and x32)
2 participants