Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swing, Powerful Mode, removed mode change bug #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amitsamanta996
Copy link

Added Control for Swings
Added Powerful Mode Control
Updated code to stop sending extra options during mode change, so now you will hear beep only once during any operation.

Added Control for Swings
Added Powerful Mode Control
Updated code to stop sending extra options during mode change, so now you will hear beep only once during any operation.
haCommandTopic: `miraie-ac/${deviceName}/+/set`,
haMonthlyPwrTopic: `miraie-ac/${deviceName}/monthly-power-consumption/state`,
haDailyPwrTopic: `miraie-ac/${deviceName}/daily-power-consumption/state`
haStatusTopic: `/ac/${deviceName}/status`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to change the topics? It will be breaking change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change the topic, i changed topic for my own requirements, however there is some topic added for mode settings, change that as needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haModeTopic in miraie.js, mode_stat_t and cmd_t in discovery.js and other changes related to this mode settings in other files.
you can keep miraie-ac no need to change to /ac
note: action mqtt and related code is removed, since home assistant action supported are cooling, heating, idle and off, and its not of much use

Copy link
Owner

@milothomas milothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @amitsamanta996, thanks for the updates and fixes. I've been a bit busy lately. Please see my comment regarding the MQTT topic changes

@orthdron
Copy link

@milothomas What changes / improvements would you like to the code so we can merge this? I need this feature and would like to help out as much as I can.

@milothomas
Copy link
Owner

@milothomas What changes / improvements would you like to the code so we can merge this? I need this feature and would like to help out as much as I can.

Hey @orthdron, I appreciate the effort, but this really is a dying project. Why dont you have a look at the HA Integration project that I started: https://github.com/milothomas/home-assistant/tree/miraie-ac

@amitsamanta996
Copy link
Author

@milothomas What changes / improvements would you like to the code so we can merge this? I need this feature and would like to help out as much as I can.

I will send you the zip file, it's working for me perfectly.

@amitsamanta996
Copy link
Author

@orthdron
rename it it package.tgz and add in node red
package.tgz.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants