-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Swing, Powerful Mode, removed mode change bug #22
base: main
Are you sure you want to change the base?
Conversation
Added Control for Swings Added Powerful Mode Control Updated code to stop sending extra options during mode change, so now you will hear beep only once during any operation.
haCommandTopic: `miraie-ac/${deviceName}/+/set`, | ||
haMonthlyPwrTopic: `miraie-ac/${deviceName}/monthly-power-consumption/state`, | ||
haDailyPwrTopic: `miraie-ac/${deviceName}/daily-power-consumption/state` | ||
haStatusTopic: `/ac/${deviceName}/status`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need to change the topics? It will be breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to change the topic, i changed topic for my own requirements, however there is some topic added for mode settings, change that as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haModeTopic in miraie.js, mode_stat_t and cmd_t in discovery.js and other changes related to this mode settings in other files.
you can keep miraie-ac
no need to change to /ac
note: action mqtt and related code is removed, since home assistant action supported are cooling, heating, idle and off, and its not of much use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @amitsamanta996, thanks for the updates and fixes. I've been a bit busy lately. Please see my comment regarding the MQTT topic changes
@milothomas What changes / improvements would you like to the code so we can merge this? I need this feature and would like to help out as much as I can. |
Hey @orthdron, I appreciate the effort, but this really is a dying project. Why dont you have a look at the HA Integration project that I started: https://github.com/milothomas/home-assistant/tree/miraie-ac |
I will send you the zip file, it's working for me perfectly. |
@orthdron |
Added Control for Swings
Added Powerful Mode Control
Updated code to stop sending extra options during mode change, so now you will hear beep only once during any operation.