-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mac] Error after downloading #3
Comments
I replaced the pdftk calls with the pure-python pyPdf Library. |
hey yvesf, nice job! It works like a charm. I’am especially exited about the support for proxies as I prefer this way to access springerlink. Do you have instructions, may I help you to test? Thank you. |
thanks for response. I've made some minor changes, now applied in my master branch. It would be nice if you could apply some testing. You can use SOCKS like this: ssh #you@your ssh login server# -D 1234 ./springer_download.py --socksaddr=localhost --socksport=1234 -l http://Spring-LINK Please Note: I've changed the sanitizeFilename routine: (hope it works) def sanitizeFilename(filename): - p1 = subprocess.Popen(["echo", filename], stdout=subprocess.PIPE) - p2 = subprocess.Popen(["iconv", "-f", "UTF-8", "-t" ,"ASCII//TRANSLIT"], stdin=p1.stdout, stdout=subprocess.PIPE) - return re.sub("\s+", "_", p2.communicate()[0].strip().replace("/", "-")) + return re.sub("\s+", "_", unicode(filename).encode("ascii", "replace").replace("/","-")) |
There seems to be some kind of timeout. I’am trying this over a sloppy cellular network right now. Will do some serious testing tomorrow morning.
|
weird, have you tried using your socks connection with a web browser? |
socks support works as expected. no problems at all over a stable connection. great. but: I had some problems yesterday with merging the downloaded pdfs. I’am sorry but I can’t provide error messages. I think it was due to some special chars. I will investigate further. Merge upstream! |
I have observed some strange behavior: I’am on a Mac and the script fails/timeouts if I have activated a (unrelated ad blocker) web proxy. If I change the network settings and deactivate the http-proxy, everything is working fine? |
there is also an issue with the sanitizeFilename function:
|
i've made a error in sanitizeFilename. Should work using last commit to yvesf/springer_download@ad1659a60b01e6b3ed54 |
yay, fantastic. thank you yvesf! |
anything I should merge into the original branch? |
@milianw yvesfs proxy support is really nice. pleae merge. |
i like the additional extraction of metadata (but not the idea to storage them in so called NFO files). |
The text was updated successfully, but these errors were encountered: