Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcoder : do not set output profile AND ICodec when adding generated stream #60

Open
valnoel opened this issue Jan 19, 2015 · 1 comment

Comments

@valnoel
Copy link

valnoel commented Jan 19, 2015

When we want to generate a stream (black or silence), we should not have to set both output profile and ICodec. The ICodec should be guessed from the profile, which must contain enough parameters to generate the stream.
It would avoid duplicated parameters into ICodec and profile.

https://github.com/mikrosimage/avTranscoder/blob/develop/src/AvTranscoder/transcoder/Transcoder.hpp#L56
https://github.com/mikrosimage/avTranscoder/blob/develop/src/AvTranscoder/transcoder/Transcoder.hpp#L66

@cchampet cchampet removed their assignment Jan 20, 2015
@cchampet
Copy link

cchampet commented Feb 9, 2015

Since a valid video/audio profile only get a codec name, we need more informations, stored in the ICodec (more exactly the xxxFrameDesc).
This is not a problem... Maybe we need to define constants in the code to define default video size, default pixel format, etc... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants