Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newgrounds: user extractor doesn't extract all item types, only art #6532

Closed
mgrandi opened this issue Nov 26, 2024 · 3 comments
Closed

Newgrounds: user extractor doesn't extract all item types, only art #6532

mgrandi opened this issue Nov 26, 2024 · 3 comments

Comments

@mgrandi
Copy link

mgrandi commented Nov 26, 2024

according to this snippet of code, it seems that passing in a newgrounds user page should try and extract all the media types, but instead it only seems to do art

https://github.com/mikf/gallery-dl/blob/d1ad97ae0c1417bbcabb84fba13ecd514ba11223/gallery_dl/extractor/newgrounds.py#L461C1-L469C21

> gallery-dl  https://theweebl.newgrounds.com --write-info-json
C:\Users\mgrandi\gallery-dl\newgrounds\theweebl\newgrounds_5403280_S4lonic.jpg
C:\Users\mgrandi\gallery-dl\newgrounds\theweebl\newgrounds_113216_Bot.png
C:\Users\mgrandi\gallery-dl\newgrounds\theweebl\newgrounds_104938_Birdy.jpg
C:\Users\mgrandi\gallery-dl\newgrounds\theweebl\newgrounds_104936_Ninj.jpg
C:\Users\mgrandi\gallery-dl\newgrounds\theweebl\newgrounds_100639_Fish Holder.png
>

image

if you pass in https://theweebl.newgrounds.com/movies , it downloads all of the movies correctly, but I think the bug is that it is not doing all of them when you pass in the user url.

gallery-dl version 1.25.5

@mikf
Copy link
Owner

mikf commented Nov 26, 2024

It downloads only art by default

You can set include to "all" to have it download from all URLs. Check with -g.

$ gallery-dl -g https://theweebl.newgrounds.com
https://theweebl.newgrounds.com/art

$ gallery-dl -g -o include=all https://theweebl.newgrounds.com
https://theweebl.newgrounds.com/art
https://theweebl.newgrounds.com/audio
https://theweebl.newgrounds.com/games
https://theweebl.newgrounds.com/movies

--write-info-json

#6317 (comment)

@mgrandi
Copy link
Author

mgrandi commented Nov 26, 2024

hmm, is that correct? newgrounds made a big push around art in recent years but i feel like the default should be to download everything, right?

and about --write-info-json, not sure if that applies, i figured that out and saw that --write-metadata seems to do what i want (which is to output a JSON file of the metadata per 'post' like that link mentions)

@mikf
Copy link
Owner

mikf commented Nov 28, 2024

gallery-dl is primarily meant as an image downloader, so downloading only art by default is "correct" in my opinion. Change it if you don't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants