Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing case of QR decomposition #69

Open
mikera opened this issue Oct 8, 2014 · 2 comments
Open

Failing case of QR decomposition #69

mikera opened this issue Oct 8, 2014 · 2 comments
Labels
bug

Comments

@mikera
Copy link
Owner

mikera commented Oct 8, 2014

The following Qr decomposition case appears to fail:

[[  0 , 0 ],
 [ -1 , 0 ]]

with results

Q= [[  0.0,  1.0 ],
    [  1.0,  0.0 ]]
R= [[ -1.0,  0.0 ],
    [  0.0, -1.0 ]]
@mikera mikera mentioned this issue Oct 8, 2014
Closed
mikera added a commit that referenced this issue Oct 8, 2014
@mikera
add failing QR test case for issue #69
e47b1eb
@mikera
Copy link
Owner Author

mikera commented Oct 8, 2014

@prasant94 any thoughts you have on how to fix this much appreciated!

@mikera mikera added the bug label Oct 8, 2014
@mikera
Copy link
Owner Author

mikera commented Oct 19, 2014

It seems that QR decomposition is currently ignoring the "error" case for QR decomposiotions. I think this is a problem for many cases - probably for any non-full-rank decoposotion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikera