E) with neutral advection #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to get model closer to Horsten thesis (2019). The net effect of these changes is to: - Increase heat conduction by 5/3 - Increase heat advection by 5/3 - Increase viscosity by 5/2 - Add viscous heating The atomic rates used in diffusion, viscosity, and heat conduction coefficients are still different from Horsten 2019.
Convert from viscous heating power to rate of change of pressure.
Intended to be similar to Wim Van Uytven et al "Assessment of advanced fluid neutral models for the neutral atoms in the plasma edge and application in ITER geometry" Nucl. Fusion 62 (2022) 086023 Significantly slows convergence; may be something wrong in implementation.
Previous commit accidentally reversed the sign of the cross-field particle flow, resulting in very poor convergence. Flux limits are now enabled by default.
- This is for testing and the Rnn term may be removed permanently later - The AFN limiters don't have this.
- For testing
Check if float option is < 0 rather than equal to -1. Remove some unused and commented-out code.
Flux limited particle flux is used in momentum flux before the momentum flux is limited. Particle flux limiter applied to advection of momentum and pressure.
Applies a time-averaging to the flux limit factors, with a given timescale. Doesn't appear to have much benefit in quick tests, but left in and turned off by default. May be removed if it really doesn't do anything useful.
Following email from Wim Van Uyten, the flux limiters have been modified: Parallel and perpendicular fluxes are used in calculating the flux limiter, but only diffusive terms are modified by flux limiter factors: - Cross-field advection due to v_perp = - D * Grad_perp(log(Pn)) - Parallel and perpendicular viscosity, - eta_n * Grad(Vn) - Parallel and perpendicular heat conduction, -kappa_n * Grad(Tn) Limiters are chained, so the cross-field particle flux limiter is used when calculating the viscosity and heat conduction limiters.
Changes after talk with Wim. Limiters now calculated from diffusive terms only and only affect diffusive terms. Also kappa and eta now correctly include particle flux limitation.
Upwinding and limiting with MC/MinMod are causing checkerboarding and/or crashes in the neutral_mixed example and provide seemingly no benefit in production runs. Reverting to original operator but with added flow diagnostics.
Probably better than deleting, we can revisit them in the future.
Upwinding and limiting with MC/MinMod are causing checkerboarding and/or crashes in the neutral_mixed example and provide seemingly no benefit in production runs. Reverting to original operator but with added flow diagnostics. Left warnings on the other operators, maybe we'll get back to them at some point.
Upwinding and limiting with MC/MinMod are causing checkerboarding and/or crashes in the neutral_mixed example and provide seemingly no benefit in production runs. Reverting to original operator but with added flow diagnostics. Left warnings on the other operators, maybe we'll get back to them at some point. Squashed with commit to update operator choice.
…es-3 into neutral-advection
…ak/hermes-3 into E-AFN-neutral-advection
mikekryjak
force-pushed
the
E-AFN-neutral-advection
branch
from
843c609 to
66a64f3
Compare
…ak/hermes-3 into E-AFN-neutral-advection
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with bendudson#212