Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ANTs commands to use antspy #32

Open
mikarubi opened this issue Sep 3, 2024 · 3 comments
Open

Convert ANTs commands to use antspy #32

mikarubi opened this issue Sep 3, 2024 · 3 comments
Assignees

Comments

@mikarubi
Copy link
Owner

mikarubi commented Sep 3, 2024

since we got rid of spark as a dependency, it makes sense to do same for ants, since it has a simple wrapper in python. https://pypi.org/project/antspyx/

it should be straightforward to convert the corresponding ants calls into python. i can give it a shot, and the advantage would be a package that can be fully installed via pip without need to install other software.

Originally posted by @mikarubi in #26 (comment)

@mikarubi mikarubi self-assigned this Sep 3, 2024
@luiztauffer
Copy link
Collaborator

that would be great! Users wouldn't need to manually install and set PATH to ANTs

@luiztauffer
Copy link
Collaborator

As of now, the tests are mostly checking if the code runs successfully and asserting that the expected files are created. I suggest we start including assertions on the content of these files, to guarantee that such a modification will work as expected

@mikarubi
Copy link
Owner Author

mikarubi commented Sep 5, 2024

Agree. I believe that the pipeline is largely deterministic, except for:

step 2: ants_registration (https://github.com/ANTsX/ANTs/wiki/antsRegistration-reproducibility-issues)).
step 3: GaussianMixture
step 4: AgglomerativeClustering
step 4: linalg.lstsq

For the purposes of such a test, we could run omit set registration='none' and set random number seeds to ensure reproducibility in other steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants