Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If condition for registration parameter #12

Open
luiztauffer opened this issue Aug 21, 2024 · 1 comment
Open

If condition for registration parameter #12

luiztauffer opened this issue Aug 21, 2024 · 1 comment

Comments

@luiztauffer
Copy link
Collaborator

The values for the parameter registration are usually strings:

'registration': 'medium', # quality of registration: 'high', 'medium', 'low' or 'none'

So this if condition will always be satisfied, the code under else will never run:

if p.registration:
save_volume(fullname_volume+ori+nii, volume, p.affine_mat)
else:
volume = volume.T
save_volume(fullname_volume+ali+hdf, volume)

In which cases the else condition should run?

@mikarubi
Copy link
Owner

correct. the idea would be to pass None, which is currently done as a string for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants