Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts won't work when modifier is present #24

Open
riccardoferretti opened this issue Jul 19, 2022 · 1 comment
Open

Keyboard shortcuts won't work when modifier is present #24

riccardoferretti opened this issue Jul 19, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@riccardoferretti
Copy link

If I try to change the status of an item using the keyboard shortcut (e.g. option+x) I get an error if there is a modifier for the item (e.g. !) and there is no space before the modifier.

To reproduce:

  1. type - [ ]! this is an item
  2. press option+x

Note that with - [ ] ! this is an item it works as expected.

@mihaiconstantin mihaiconstantin added the bug Something isn't working label Aug 10, 2022
@mihaiconstantin
Copy link
Owner

Thanks for pointing this out, @riccardoferretti, and apologizes for the slow response—I was away for a few weeks.

I believe the issue occurs here:

const pattern = Pattern.extractSymbol(symbol);

Because the Pattern.extractSymbol(symbol) fails to identify the line as a valid BuJo entry. This can be seen in the regex demo (i.e., https://regex101.com/r/ABVEf2/4) for the following text:

- [ ]! Some example task ^2rj7bd6p8pph

I will fix the regex pattern and push out an update. Thanks for catching this!

@mihaiconstantin mihaiconstantin self-assigned this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants