-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build faliure - mondo-minimal #67
Comments
@LucieContamin , I think i have temporarily fixed this by pointing the build process directly at an older version of the midas-minimal.owl file. Please run the action and take a look to see if it looks ok. I'm trying to get an answer from Bill Hogan as to whether there's a more durable fix. |
It seems that the GitHub Action has already re-run with success and the last version with the license has been deployed. I am afraid that if I trigger the Action again it will create a new release without any change |
Ok. that’s fine. I’m going to continue to look for a more permanent fix.
…-harry
From: Lucie Contamin ***@***.***>
Date: Wednesday, November 6, 2024 at 8:34 AM
To: midas-network/midas-data ***@***.***>
Cc: Hochheiser, Harry ***@***.***>, Author ***@***.***>
Subject: Re: [midas-network/midas-data] build faliure - mondo-minimal (Issue #67)
It seems that the GitHub Action has already re-run with success and the last version with the license has been deployed. I am afraid that if I trigger the Action again it will create a new release without any change
—
Reply to this email directly, view it on GitHub<#67 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABKU43ZTN3O7LQ6VR6X3FDZ7ILHTAVCNFSM6AAAAABRHICKAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZG43DSMRTG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
From @JohnLevander: Hi Harry, A few updates on this issue..
Plan: I think the best solution is to get mondo to include mondo-minimal in their release. If they do that, we are done messing with this issue. I filed an issue with their team here: monarch-initiative/mondo#7912. If they can't/won't include mondo-minimal in their release, I also asked them if they could provide guidance on how to "trim" down the release ontology to make it contain only the "minimal" entries. Hopefully it won't be that hard if it comes down to that. I have other ideas, but let's see what mondo says first. In the meantime if we want to create a release, we should be able to do it locally: https://www.browserstack.com/guide/test-github-actions-locally |
Thanks, @JohnLevander. Note that it's working ok for now based simply on pulling back to the last released version of mondo-minimal. A couple of points:
I'm going to try to look into #1. |
Hello @harryhoch and @JohnLevander! I made a PR here #68 that replaces mondo minimal by "simple", which is very close to the old (now deprecated) minimal subset. Some additional observations:
|
ok thanks. I think this is working. |
Seems to blow up when trying to pull in mondo-minimal
Mondo Release
The text was updated successfully, but these errors were encountered: