From 82c9fe78a60e0d37e2f31851c1c9fea5f6190cfa Mon Sep 17 00:00:00 2001
From: Philip Gichuhi <pgichuhi@microsoft.com>
Date: Tue, 19 Nov 2024 12:34:07 +0300
Subject: [PATCH] Add android lint baseline file

---
 android/build.gradle      | 14 +++++---------
 android/lint-baseline.xml | 22 ++++++++++++++++++++++
 2 files changed, 27 insertions(+), 9 deletions(-)
 create mode 100644 android/lint-baseline.xml

diff --git a/android/build.gradle b/android/build.gradle
index 884e2c04..0d352d25 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -43,20 +43,16 @@ android {
         targetCompatibility JavaVersion.VERSION_1_8
     }
 
+    lint {
+        baseline = file("lint-baseline.xml")
+    }
+
     lintOptions {
         textOutput "stdout"
         checkAllWarnings true
         warningsAsErrors true
-        disable "UnusedResources"              // Unused will be removed on release
-        disable "IconExpectedSize"             // Using the material icons provided from Google
-        disable "GoogleAppIndexingApiWarning"  // We might want to index our app later
-        disable "InvalidPackage"               // Butterknife, Okio and Realm
-        disable "ResourceType"                 // Annotation binding
-        disable "GradleDependency"
-        disable "NewerVersionAvailable"
-        disable "DuplicatePlatformClasses"      // xpp3 added by azure-identity
-        disable "LambdaLast"
     }
+
     sourceSets {
         main {
             java.srcDirs = ['../src/main/java']
diff --git a/android/lint-baseline.xml b/android/lint-baseline.xml
new file mode 100644
index 00000000..be568d61
--- /dev/null
+++ b/android/lint-baseline.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.7.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.7.2)" variant="all" version="8.7.2">
+
+    <issue
+        id="InvalidPackage"
+        message="Invalid package reference in com.azure:azure-xml; not included in Android: `javax.xml.stream`. Referenced from `com.azure.xml.XmlReader`.">
+        <location
+            file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/com.azure/azure-xml/1.1.0/8218a00c07f9f66d5dc7ae2ba613da6890867497/azure-xml-1.1.0.jar"/>
+    </issue>
+
+    <issue
+        id="LambdaLast"
+        message="Functional interface parameters (such as parameter 1, &quot;tokenCredential&quot;, in com.microsoft.graph.core.requests.GraphClientFactory.create) should be last to improve Kotlin interoperability; see https://kotlinlang.org/docs/reference/java-interop.html#sam-conversions"
+        errorLine1="    public static OkHttpClient.Builder create(@Nonnull final TokenCredential tokenCredential, @Nonnull final RequestOption[] requestOptions) {"
+        errorLine2="                                                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="${:*debug*MAIN*sourceProvider*0*javaDir*0}/com/microsoft/graph/core/requests/GraphClientFactory.java"
+            line="73"
+            column="95"/>
+    </issue>
+
+</issues>