Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change missing method GetError to GetErrorEscaped in docs #802

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

JacieChao
Copy link
Contributor

@JacieChao JacieChao commented Nov 12, 2024

Overview

Update the README docs with ODataError change which changed the method name from GetError() to GetErrorEscaped()

fixes #690

baywet
baywet previously approved these changes Nov 12, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed another instance of the issue.
Would you mind replicating the changes to this one as well please?
https://github.com/microsoftgraph/msgraph-beta-sdk-go/

@baywet baywet enabled auto-merge (squash) November 12, 2024 09:35
@baywet baywet merged commit a515bd2 into microsoftgraph:main Nov 12, 2024
6 checks passed
@JacieChao
Copy link
Contributor Author

@baywet Sure. I'd love to. The new PR will be microsoftgraph/msgraph-beta-sdk-go#476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic examples in documentation are wrong
2 participants