Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/trimming #2174

Merged
merged 2 commits into from
Oct 24, 2023
Merged

feature/trimming #2174

merged 2 commits into from
Oct 24, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 20, 2023 •
edited by andrueastman
Loading

@baywet baywet self-assigned this Oct 20, 2023
@baywet baywet marked this pull request as ready for review October 24, 2023 12:46
@baywet baywet requested a review from a team as a code owner October 24, 2023 12:46
@baywet baywet merged commit 37e3d70 into dev Oct 24, 2023
5 checks passed
@baywet baywet deleted the feature/trimming branch October 24, 2023 12:46
@baywet
Copy link
Member Author

baywet commented Oct 24, 2023

@andrueastman would you mind replicating on beta please?

@andrueastman
Copy link
Member

@andrueastman would you mind replicating on beta please?

No worries. Will do.

pschaeflein
pschaeflein reviewed Oct 24, 2023
View reviewed changes
src/Microsoft.Graph/Microsoft.Graph.csproj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeting net5.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an additional target, we're also still shipping standard 2.0 and 2.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. But why 5.0? It is out of support. Would net7.0 be better? Or wait a month for net8.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's the lowest that supports trimming? and dotnet 5/7/8 projects are going to resolve to the net5 assembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschaeflein pschaeflein pschaeflein left review comments

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baywet @andrueastman @pschaeflein