Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Classify release job to comply with 1ES standard #938

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Nov 27, 2024

closes #935

Microsoft Reviewers: Open in CodeFlow

@Ndiritu Ndiritu self-assigned this Nov 27, 2024
@Ndiritu Ndiritu marked this pull request as ready for review November 27, 2024 14:15
@Ndiritu Ndiritu requested a review from a team as a code owner November 27, 2024 14:15
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold the merge until we've had a v1 release since my changes in v1 have NOT been tested yet. Whenever v1 5.64.0 is out, this should be good to merge.

@baywet
Copy link
Member

baywet commented Nov 28, 2024

confirmed, the changes work. Merging.

@baywet baywet force-pushed the chore/release-pipeline-compliance branch from f845479 to 990731b Compare November 28, 2024 13:19
@baywet baywet enabled auto-merge November 28, 2024 13:19
@baywet baywet merged commit 756ff7a into main Nov 28, 2024
5 checks passed
@baywet baywet deleted the chore/release-pipeline-compliance branch November 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security: add missing security metadata to the pipeline
2 participants