Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph SDK V5: Default RetryHandler does not provide info on why it failed #816

Closed
DCourtel opened this issue Mar 21, 2024 · 1 comment
Closed

Comments

@DCourtel
Copy link

The default retry handler simply throws an InvalidOperationException exception when it reaches the maximum retry count. The error message is simply set to: «Too many retries performed.» and the inner exception simply states: «More than {retryCount} retries encountered while sending the request.»
There is no way to know why retries have been performed. What were the error codes and error messages?

The retry handler should return an AggregateException (or a specific exception like TooManyRetriesException) with one exception per retry specifying the HTTP status and the error code returned by the server.

Thanks.

Source: Microsoft.Kiota.Http.HttpClientLibrary.Middleware.RetryHandler

@andrueastman
Copy link
Member

Thanks for raising this @DCourtel

I believe this is a valid ask. As this is related to the http library, we'll close this here and track this from the library via microsoft/kiota-http-dotnet#221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants