Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocklist certain warnings from bindgen #138

Open
wmmc88 opened this issue Apr 9, 2024 · 0 comments
Open

blocklist certain warnings from bindgen #138

wmmc88 opened this issue Apr 9, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wmmc88
Copy link
Collaborator

wmmc88 commented Apr 9, 2024

// FIXME: this currently sets the minimum log level to error for the listed modules. It should actually be turning off logging (level=off) for specific warnings in these modules, but a bug in the tracing crate's filtering is preventing this from working as expected. See https://github.com/tokio-rs/tracing/issues/2843.

Certain warnings from bindgen are not actionable by WDR due to upstream work required. These warnings should be individually silenced instead of turning off all warnings for the bindgen module. This is currently not possible because tracing's envfilter does not have functional field value matching for logs, only for spans. See tokio-rs/tracing#2843. Since bindgen is using logs instead of traces, this probably involves fixing something in tracing-log

@wmmc88 wmmc88 added enhancement New feature or request help wanted Extra attention is needed labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant