Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate tree element ids in problems panel #76103

Closed
joaomoreno opened this issue Jun 25, 2019 · 4 comments
Closed

Duplicate tree element ids in problems panel #76103

joaomoreno opened this issue Jun 25, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 25, 2019

Testing #74824 on macOS

When following the steps from that test plan item, right after

Try changing the "fileLocation" in the task to "absolute"

... and running the task once more, you end up creating more errors on the same file, but it appears as a different file on the problems panel.

When this happens, several elements in the tree have the same ID. You can validate this by click some errors and noticing others also get focused/selected.

image

image

@jrieken jrieken removed their assignment Jun 25, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Jun 25, 2019
@sandy081 sandy081 added this to the July 2019 milestone Jun 25, 2019
@sandy081
Copy link
Member

Will make sure that markers do not share the same id.

@sandy081
Copy link
Member

@alexr00 I made ids of markers unique and the rest is not to generate duplicate resource entries for the same resource. I would leave that to you as I guess it is coming from tasks.

@sandy081 sandy081 assigned sandy081 and unassigned sandy081 Jun 28, 2019
@sandy081 sandy081 removed their assignment Jun 28, 2019
@alexr00
Copy link
Member

alexr00 commented Jul 11, 2019

Since the duplicate resources come from different tasks, we should instead clear all task markers from tasks that aren't currently running when the configuration changes.

@alexr00
Copy link
Member

alexr00 commented Jul 11, 2019

Thinking about it some more, I don't think we should just remove users task related problems without any visible reason. Instead, the best approach would be to provide a command that removes all task related problems.

However, I don't think that would get much use. New backlog item: #77214

@alexr00 alexr00 closed this as completed Jul 11, 2019
@roblourens roblourens added the verified Verification succeeded label Jul 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants