Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply problem matchers #68704

Closed
Gruntfuggly opened this issue Feb 14, 2019 · 4 comments
Closed

Re-apply problem matchers #68704

Gruntfuggly opened this issue Feb 14, 2019 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tasks Task system issues
Milestone

Comments

@Gruntfuggly
Copy link

When trying to create problem matchers, it would be really handy if the problems view was refreshed when the tasks.json was saved.

@vscodebot
Copy link

vscodebot bot commented Feb 14, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the tasks Task system issues label Feb 14, 2019
@alexr00 alexr00 added the feature-request Request for new features or functionality label Feb 14, 2019
@alexr00 alexr00 added this to the On Deck milestone Feb 14, 2019
@justingrant
Copy link
Contributor

This would be a huge help. I'm in the middle of spending multiple hours to create and troubleshoot a custom problem matcher for create-react-app. Most of that wasted time is spent closing my VSCode window or restarting the VSCode process in order to clear the problems list, because without the problems list being cleared I can't tell if the latest iteration of the problem matcher is actually working correctly (because the problems are still there even after I CTRL+C to end the npm start background task). Each restart wastes 30-60 seconds. I've had to do it 50+ times. This gets old.

In addition to refreshing problems when tasks.json is saved, I think we should also clear problems from a background task (not a non-background task though) when the task exits. The nature of a background task is that it's supposed to be running in the background. Once it's not running anymore, keeping its problems around doesn't make sense. I'd also be OK if this were an option on the task config to avoid breaking backwards compat if there are users who like the current behavior.

Finally, it would be really, really helpful if there was some kind of diagnostic option when building and troubleshooting problem matchers. When a problem isn't matched, e.g. because of an error in a regex, I have no idea which regex or config option is not working. I'd love to be able to get some sort of verbose console output or logfile that lists which regexes matched, which didn't, and any errors that happened (e.g. endsPattern or beginsPattern not matched, invalid filename, etc.)

@alexr00
Copy link
Member

alexr00 commented Oct 16, 2019

#77214 would also solve this.

@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 16, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 16, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 16, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants