Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coffeescript] syntax highlighting breaks on indented comment blocks #14945

Closed
pzuraq opened this issue Nov 3, 2016 · 7 comments
Closed

[coffeescript] syntax highlighting breaks on indented comment blocks #14945

pzuraq opened this issue Nov 3, 2016 · 7 comments
Assignees
Labels
languages-basic Basic language support issues
Milestone

Comments

@pzuraq
Copy link

pzuraq commented Nov 3, 2016

  • VSCode Version: 1.7.0
  • OS Version: 10.11.6

Steps to Reproduce:

  1. Add comment block (three hashtags in a row)
  2. Indent comment block

screen shot 2016-11-03 at 3 55 09 pm

@pzuraq
Copy link
Author

pzuraq commented Nov 4, 2016

This appears to be caused by the lookbehind used in the regular expression marking the beginning of a comment block here. For some reason, this expression matches all characters except for empty spaces.

A temporary fix on my machine is to change the expression from (?<!#)###(?!#) to ^[^#]*###(?!#), though this would possibly break for multiple block comments on a single line.

@tonythomson
Copy link

Per @aeschli, VSC's CoffeeScript grammar is from https://github.com/textmate/coffee-script.tmbundle. There is a corresponding issue in that repo.

@pzuraq
Copy link
Author

pzuraq commented Dec 20, 2016

Any word on this and #15008? I've been fixing it manually but whenever VSCode updates it wipes that out. Really tedious for me, would love to fix it if I can help.

@drKnoxy
Copy link

drKnoxy commented Dec 21, 2016

They already have a PR in for the fix ... textmate/coffee-script.tmbundle#11

@pzuraq
Copy link
Author

pzuraq commented Dec 27, 2016

@drKnoxy seems to be dead in the water, and there isn't a fix for #15008. Are we sure that the maintainers of that package are active?

@drKnoxy
Copy link

drKnoxy commented Dec 28, 2016

Probably inactive, I hear everyone is switching from textmate to vscode (har har har)

@aeschli aeschli added this to the February 2017 milestone Jan 31, 2017
@aeschli aeschli changed the title Coffeescript syntax highlighting breaks on indented comment blocks [coffeescript] syntax highlighting breaks on indented comment blocks Jan 31, 2017
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2017

Fixed by switching to the atom/language-coffee-script grammar.

@aeschli aeschli closed this as completed Jan 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

5 participants