-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not respect workspaceMount, workspaceFolder when using "Open repository in container" #3034
Comments
@chrmarti I know we're ignoring |
I think If only |
Is there any fix on this. I need workspace to be mounted on /var/www/html. For workaround I use symlink. |
It would be nice if the workspace was checked out in the |
Could someone help me understand this comment from above?
As a user, I don't know how the volume hosting the repo is laid out, but when I open a repository in a container I would expect the Having the file system layout differ depending on how the user launched the container somewhat defeats the purpose of a consistent dev environment for me, and it means I can't easily implement a workaround in my Docker image. As an additional piece, the fact that these properties are silently ignored is rather confusing; if I didn't know to do an issues search on this repo I would be assuming it was a bug or misconfiguration. cc @Chuxel |
@WasabiFan workspaceMount dictates where the source code comes from in addition to where it goes to in the container. In this case the source code is in the root of a volume, so the "src" doesn't apply. |
Any ideas on how to solve this? It becomes quite important for e.g. typescript development on Windows, since "npm install" and bind mounts is a painful experience due to how Docker for Windows is designed. Additionally, this is needed to work with e.g. shell scripts since Docker for Windows seems to not handle Unix permissions well (again, due to poor design choices by Docker, not the fault of this extension). I think respecting workspaceFolder sounds like a reasonable solution, at least from a user point of view. |
@rickardp This is a feature request though I noticed it wasn't tagged. If you need to use another path, a simple workaround is to use a symbolic link. For /var/www/html, you can add Since |
@Chuxel Thanks. In my particular case this does not work unfortunately. The "workaround" is to run Docker off a Linux VM at the moment, quirky but works well once set up. The expectation though was that workspaceFolder was respected, and although I get that you want to treat it as a new feature, I would argue that the logical conclusion from users is that it would work the same way regardless how you clone the repo. |
Same cause as #5388. |
I'd really like to see this addressed as it is blocking us from being able to provide a single click link to launch into our devcontainer as described here: https://code.visualstudio.com/docs/devcontainers/create-dev-container#_add-an-open-in-dev-container-badge I think this is a killer feature of projects that use devcontainers and it is really a bummer to not be able to take advantage of it. |
Steps to Reproduce:
Expected behavior is that the mount point is respected. This is important for my use case since the build system expects the source code to be placed under /src (repurposing an existing Docker-based build system as the dev container).
The text was updated successfully, but these errors were encountered: