Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a version on a devcontainer feature breaks feature option intellisense #10090

Closed
Clockwork-Muse opened this issue Jul 22, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Milestone

Comments

@Clockwork-Muse
Copy link

Version:

  • VSCode Version: 1.91.1 (user setup)
    • Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
    • Date: 2024-07-09T22:06:49.809Z
    • Electron: 29.4.0
    • ElectronBuildId: 9728852
    • Chromium: 122.0.6261.156
    • Node.js: 20.9.0
    • V8: 12.2.281.27-electron.0
  • Local OS Version: Windows_NT x64 10.0.22631
  • Remote OS Version: Ubuntu 22.04
  • Remote Extension/Connection Type: Containers/WSL/Server

When adding a feature to a devcontainer, intellisense for feature options does not appear if a version (or even just the colon separator) is specified.
Without feature version:
image
With feature version:
image

  • Logs:

Steps to Reproduce:

  1. With the following devcontainer:
{
	"name": "Alpine",
	"image": "mcr.microsoft.com/devcontainers/base:alpine-3.20",
	"features": {
		"ghcr.io/devcontainers/features/azure-cli:1.2.5": {

		}
	}
}
  1. Place the cursor between the two open brackets for the azure-cli feature and hit Ctrl+Space.
  2. Observe that intellisense returns a set of "unrelated" text, not the options for the feature.

Does this issue occur when you try this locally?: Yes
Does this issue occur when you try this locally and all extensions are disabled?: Yes

@vs-code-engineering vs-code-engineering bot added the containers Issue in vscode-remote containers label Jul 22, 2024
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jul 29, 2024
@chrmarti chrmarti added this to the August 2024 milestone Jul 29, 2024
@chrmarti
Copy link
Contributor

This fix is available in Dev Containers 0.381.0-pre-release.

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 28, 2024
@rzhao271
Copy link

On 0.382.0 pre-release, I get "No code actions available" no matter whether or not I have a version set.

@rzhao271 rzhao271 reopened this Aug 28, 2024
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Aug 28, 2024
@chrmarti
Copy link
Contributor

The issue was that there were no specific IntelliSense suggestions (only the unspecific word collection). There are no code actions at the moment.

To verify please check if you get IntelliSense with suggestions that match the feature's options, e.g.:
Image

@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants