Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactor - Activation of environments #2789

Closed
DonJayamanne opened this issue Oct 4, 2018 · 1 comment
Closed

Code Refactor - Activation of environments #2789

DonJayamanne opened this issue Oct 4, 2018 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Oct 4, 2018

I leave the design upto @d3r3kk

Requirements:

  • Move the classes and interfaces into an area related to Interpreters.
  • Support multiple shells
  • Support multiple OS
  • Configure priority for activation providers/services (stratergy classes).
    E.g. First check env is conda, then activate using conda activation mechanism,
    Then we might need to try pipenv, and then virtual env, etc.
    Note: If one fails, we need to try others (i.e. priority queue).
  • Support a fallback mechanism.
    E.g. if activating from powershell isn't possible but command prompt is, then we can go into CMD and activate as though it was a command prompt.

Testing requirements

@DonJayamanne DonJayamanne added needs PR needs proposal Need to make some design decisions labels Oct 4, 2018
@DonJayamanne DonJayamanne added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Oct 4, 2018
@microsoft microsoft locked and limited conversation to collaborators Oct 4, 2018
@DonJayamanne DonJayamanne changed the title Refactor activation of terminals Code Refactor - Activation of terminals Oct 4, 2018
@DonJayamanne DonJayamanne changed the title Code Refactor - Activation of terminals Code Refactor - Activation of environments Oct 4, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Jan 28, 2019

Closing as all required features/changes have since been implemented.

@ghost ghost removed needs PR needs proposal Need to make some design decisions labels Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants