Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] Settings option "html.format.wrapAttributes" and "html.format.wrapAttributesIndentSize" #1350

Open
LWChris opened this issue May 8, 2023 · 1 comment

Comments

@LWChris
Copy link

LWChris commented May 8, 2023

The settings html.format.wrapAttributes and html.format.wrapAttributesIndentSize are translating "wrap" with "umschließen". The correct translation in this context is "umbrechen".

  • "umschließen" literally translates "to enclose, to surround" (wrapped in a blanket)
  • "umbrechen" literally translates "to break over" (line wrap / line break context)

These two options seem to be in bad shape in general, as there are several other quality issues with them as discussed below.

html.format.wrapAttributes

Description:
de wrong: "Attribute umschließen."
de correct: "Attribute umbrechen."
Option "auto" tooltip:
de wrong: "Attribute nur dann umschließen, wenn die Zeilenlänge überschritten wird."
de correct: "Attribute nur dann umbrechen, wenn die Zeilenlänge überschritten wird."
Option "force" tooltip:
de wrong: "Jedes Attribut mit Ausnahme des ersten umschließen."
de correct: "Jedes Attribut mit Ausnahme des ersten umbrechen."
Option "force-aligned" tooltip:
de wrong: "Jedes Attribut mit Ausnahme des ersten umschließen und Ausrichtung beibehalten."
de correct: "Jedes Attribut mit Ausnahme des ersten umbrechen und Ausrichtung beibehalten."
Option "force-expand-multiline" tooltip:
de wrong: "Jedes Attribut umschließen."
de correct: "Jedes Attribut umbrechen."

(Option "aligned-multiple" is correct)

Option "preserve" tooltip:
de wrong: "Umbruch von Attributen beibehalten"
de correct: "Umbruch von Attributen beibehalten." // Added full stop for consistency with other tooltips
Option "preserve-aligned" tooltip:
de wrong: "Ausrichten, aber Umschließung von Attributen beibehalten."
de correct: "Ausrichten, aber Umbruch von Attributen beibehalten."

Additional considerations:

  • The style of tooltip phrazing is quite different between aligned-multiple, preserve, and preserve-aligned, versus all the options. While the others use the verb "umbrechen", these three use the noun "Umbruch". I have no real preference for one of the two styles, but I'm up to provide a unified set of tooltips for all options if so desired.

html.format.wrapAttributesIndentSize

Description:
de wrong: "Rücken Sie umschlossene Attribute nach „N“ Zeichen ein. Verwenden Sie „NULL“, um die Standardeinzugsgröße zu verwenden. Dies wird ignoriert, wenn „#html.format.wrapAttributes#“ auf „aligned“ festgelegt ist."
de correct: "Rücken Sie umgebrochene Attribute um „N“ Zeichen ein. Verwenden Sie „NULL“, um die Standardeinzugsgröße zu verwenden. Dies wird ignoriert, wenn „#html.format.wrapAttributes#“ auf „aligned“ festgelegt ist."

Additional considerations:

  • „N“ should probably be „n“, because it's a placeholder for a number
  • „NULL“ should probably formatted null for consistency with other options such as html.format.unformatted
  • „#html.format.wrapAttributes#“ link doesn't work; it should be fixed and also used without quotes (working example: editor.insertSpaces)
  • there is no option named „aligned“, but there are multiple options that will probably override this setting; I suppose this is still intuitive though
@csigs
Copy link
Member

csigs commented May 8, 2023

Thank you for your feedback. We are currently reviewing it (reference 827907).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants