Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override the themes used in plotting packages #11670

Closed
joelostblom opened this issue Oct 16, 2022 · 2 comments
Closed

Do not override the themes used in plotting packages #11670

joelostblom opened this issue Oct 16, 2022 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@joelostblom
Copy link

Is it possible to use a light theme for vegalite/altair when the dark theme is enabled in VS Code? This is a quite important use case since it allows you to see what the plot would look like for others outside the editor. It seems like setting it back to "default" does not work and it is still dark:

image

Also see vega/vega-themes#413

Environment data

This was reported by one of my students so I am not sure about the exact env information

Expected behaviour

The vega/vegalite/altair themes are not overridden by the editor.

Actual behaviour

The editor overrides the theme of the charts

@joelostblom joelostblom added the bug Issue identified by VS Code Team member as probable bug label Oct 16, 2022
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality discuss-at-standup and removed bug Issue identified by VS Code Team member as probable bug labels Oct 16, 2022
@joelostblom
Copy link
Author

It seems like this is only happening when using alt.renderers.enable('mimetype') :

image

image

@DonJayamanne
Copy link
Contributor

Unfortunately there haven't been sufficient upvotes on this issue
Hence closing this as out of scope.

@DonJayamanne DonJayamanne added the *out-of-scope Posted issue is not in scope of VS Code label Dec 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants