Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting an extension when that extension's output is selected in the "Output" pane should not change which extension is selected in the "Output" pane. #1898

Open
GageSorrell opened this issue Jun 23, 2024 · 3 comments
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@GageSorrell
Copy link

Current Behavior

Suppose the "Output" pane is visible, and a given extension's output is being viewed.

If the user runs the "Restart" command for that extension (for example, the TypeScript LSP, or the ESLint extension), the selected extension of the "Output" pane changes.

Statement of Issue

If a user restarts an extension and is viewing the output of that extension, they almost certainly will want to see the output of the extension upon restarting the extension.

Proposed Behavior

When restarting an extension, I propose that the selected extension in the "Output" pane remain unchanged.

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jun 24, 2024
@sandy081 sandy081 modified the milestone: June 2024 Jun 24, 2024
@sandy081 sandy081 added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Jun 24, 2024
@sandy081
Copy link
Member

I am not able to reproduce this. Can you please provide the exact steps to repro?

@GageSorrell
Copy link
Author

  1. Open a Workspace that has the ESLint extension enabled (I have also tested this with the TypeScript LSP)
  2. Focus the "Output" pane, then choose ESLint from the dropdown menu
  3. Ctrl+P, then select the "Restart the ESLint server" command

Once this is done, the value of the dropdown menu changes (for me) to the output of "Tasks", which seems to be arbritrary.

@sandy081 sandy081 transferred this issue from microsoft/vscode Jul 9, 2024
@sandy081 sandy081 removed their assignment Jul 9, 2024
@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Jul 9, 2024
@sandy081
Copy link
Member

sandy081 commented Jul 9, 2024

This seems to be an issue with eslint extension. It might be disposing the chanel and creating it again on restarting the ES Lint Server. When an output channel is disposed a default channel is shown.

@dbaeumer dbaeumer added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Jul 9, 2024
@dbaeumer dbaeumer added this to the Backlog milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

3 participants