Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copilot Hover uses incomplete definitions for templated methods #13113

Open
spebl opened this issue Jan 6, 2025 · 3 comments
Open

Copilot Hover uses incomplete definitions for templated methods #13113

spebl opened this issue Jan 6, 2025 · 3 comments
Labels
bug Feature: Copilot Context Integration with GitHub Copilot that provides additional context info Feature: Copilot Hover GitHub Copilot hover "Generate Copilot summary" feature Language Service

Comments

@spebl
Copy link
Contributor

spebl commented Jan 6, 2025

The context does not seem to include all keywords and parameters listed in the declaration/definition, and in some cases, it fails to retrieve the definition at all.
@spebl spebl added Feature: Copilot Context Integration with GitHub Copilot that provides additional context info Feature: Copilot Hover GitHub Copilot hover "Generate Copilot summary" feature labels Jan 6, 2025
@sean-mcmanus
Copy link
Contributor

@spebl Is this just the bug with template <> being missing from the beginning of the definition? Or are there more repro scenarios? When exactly is a case where the definition is not retrieved?

@spebl
Copy link
Contributor Author

spebl commented Jan 9, 2025

I believe @kuchungmsft has been looking at these scenarios most recently.

I believe there were cases with traversing template function symbols in edg to get to the actual function definition that weren't working along with the keywords and template types being filled in.

@kuchungmsft
Copy link
Contributor

Yeah, I think this would be resolved by the full declaration position pull request on the language server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Feature: Copilot Context Integration with GitHub Copilot that provides additional context info Feature: Copilot Hover GitHub Copilot hover "Generate Copilot summary" feature Language Service
Projects
cpptools
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bobbrow @sean-mcmanus @spebl @kuchungmsft