Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic proxy should implement IAsyncDisposable as well #645

Open
AArnott opened this issue Feb 18, 2021 · 0 comments
Open

Dynamic proxy should implement IAsyncDisposable as well #645

AArnott opened this issue Feb 18, 2021 · 0 comments

Comments

@AArnott
Copy link
Member

AArnott commented Feb 18, 2021

Our dynamic proxies today implement only IDisposable. By implementing IAsyncDisposable as well, even though local disposal will continue to complete synchronously, clients that know the service's concrete type implements IAsyncDisposable can go on disposing the async way without failing when the interface they have is to an RPC proxy.

interfaces.Add(typeof(IJsonRpcClientProxy));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant