-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Order Downloading / Installing #179
Comments
IMO this issue blocks #164 |
Wondering if this was an issue before Lumin was added? Is it an issue with the order in general? I just added it to the end of the list, and implemented the corresponding component checks. |
Ah, yes, it is unrelated to Lumin. We return in order of the enum, but that assumes you aren't installing the core installers from other platforms. |
Thinking we should process all the contents of the pipeline to determine components that are missing, then put the platform installer at the front, then install. Thoughts on that? |
Workaround Pass all the installers to the Note: We'll make this simple pipelining work across platforms in the near future without any sorting on your part. |
I think this is also related to #162. We should likely include the editor platform by default based on the detected OS |
Having a list of installers with the
Lumin
installer in the list fails to properly install theLumin
component because of download and install order.Install starts by downloading only
Lumin
before the editor and other components and then attempts to installLumin
which then fails since the editor was not downloaded and installed first.Commands to repro below. (Assumes fresh install.)
The text was updated successfully, but these errors were encountered: