Implement new resource "AWS Service Endpoint"

[EliiseS]

---

Migrated from #370
Originally created by @simongottschlag on Tue, 09 Jun 2020 21:02:33 GMT

---

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Implement AWS Service Endpoint.

New or Affected Resource(s)

• azuredevops_serviceendpoint_aws

References

https://github.com/aws/aws-toolkit-azure-devops

https://aws.amazon.com/vsts/

• #0000

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @xuzhang3 on Fri, 12 Jun 2020 10:19:20 GMT

---

So I implemented an AWS service endpoint resource.
https://github.com/phillebaba/terraform-provider-azuredevops/blob/aws-service-connection/azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_aws.go

The only thing that does not seem to work are the confidential values. The paramters secret_access_key and session_token are not returned by the api, causing issues with the state. @xuzhang3 do you know what might cause this, or is this an issue on AWS side that needs to be fixed?

@phillebaba Thanks for you contribute, wonderful work. I'm not experience with AWS, I guess that secret_access_key and session_token can only get from AWS portal or CLI. You can reference here Bitbucket handle password , password won't return by API too.

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @phillebaba on Thu, 11 Jun 2020 22:01:50 GMT

---

So I implemented an AWS service endpoint resource.
https://github.com/phillebaba/terraform-provider-azuredevops/blob/aws-service-connection/azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_aws.go

The only thing that does not seem to work are the confidential values. The paramters secret_access_key and session_token are not returned by the api, causing issues with the state. @xuzhang3 do you know what might cause this, or is this an issue on AWS side that needs to be fixed?

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @xuzhang3 on Fri, 12 Jun 2020 10:22:23 GMT

---

@phillebaba I assign this task to you.

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @xuzhang3 on Wed, 10 Jun 2020 05:32:17 GMT

---

Potential HCL config:

resource "azuredevops_serviceendpoint_aws" "aws_serviceendpoint" {
  project_id            = azuredevops_project.project.id
  access_key_id         = "xxxx"
  secret_access_key     = "xxxx"
  service_endpoint_name = "aws_serviceendpoint"
  description           = "Managed by AzureDevOps"
}

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @xuzhang3 on Wed, 17 Jun 2020 03:17:24 GMT

---

@phillebaba We use Terraform acceptance test framework for testing, acceptance test will create real resource and destroy it after test finished (Acceptance Test Document). You don't need to judge whether the organization has installed the aws-toolkit-extension. When required resource not found, service API will return an error and acceptance test failed.

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @phillebaba on Tue, 16 Jun 2020 20:30:02 GMT

---

@xuzhang3 I made the changes so that the state is not out of sync all the time. I am not familiar with how your testing environment looks like though. Should I go ahead and implement a test that just assumes that aws-toolkit-azure-devops is installed?

[EliiseS]

---

Migrated from #370 (comment)
Originally created by @phillebaba on Tue, 16 Jun 2020 08:47:54 GMT

---

I looked a bit closer at how the other resources did and realized that they do not store the secret as it is not returned by the API. Instead they use a custom diff function and a hash of the secret to detect when any changes are made.

I will change my secrets handling to it works in the same way, and I guess it should work.

[EliiseS]

@phillebaba Can you comment on this issue so I can assign you back?

Context: isaacs/github#100 (comment)

[phillebaba]

Thank you for moving the PR! Did not know you could do this in Github.

[xuzhang3]

@phillebaba We can only move the issues, cannot move the PR, you need submit another :D

[phillebaba]

Oh, I was a bit too optimistic there I guess. Sorry for not getting to this earlier, but I have had a lot on my plate the last two weeks. Now there is a PR in the correct repo with the same changes.

[phillebaba]

We can close this issue, as the PR has been merged.