Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better treatment of packages that depend on beta (versioning mismatch) #10290

Open
thomasjball opened this issue Nov 25, 2024 · 1 comment
Open
Assignees

Comments

@thomasjball
Copy link
Contributor

Try the following:

  1. load https://github.com/microbit-apps/pxt-arcadeshield in https://makecode.microbit.org/beta (WORKS)
  2. load https://github.com/microbit-apps/pxt-arcadeshield in https://makecode.microbit.org (FAILS, silently)

The WORKS and FAILS behaviors are expected, but the silent FAIL is not great. When there is a version mismatch (as above in (2)), we should have a nicer message.

@tballmsft tballmsft self-assigned this Nov 25, 2024
@tballmsft
Copy link
Contributor

The silent failure is here

pxtapp.js:1  Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'pxt.json')
    at n.getConfigAsync (pxtapp.js:1:279221)
    at pxtapp.js:1:285290

the code path is

            if (!i.startsWith("pub:")) {
                const s = e.patching.upgradePackageReference(t, n, i)
                  , r = e.appTarget.bundledpkgs[s];
                return JSON.parse(r[e.CONFIG_NAME])
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants