Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pxt core bump 9.1.1x and more #1038

Merged
merged 24 commits into from
Nov 3, 2023
Merged

Conversation

THEb0nny
Copy link
Contributor

Increased pxt-core version for timely support.

Additionally, there is a change in the programming language switch.
A visual bug could appear at different scales.
#editortoggle.ui.grid.padded it may be a little more than 45 in height, but the background fill element (.ui.item.toggle.dropdown-attached) is always 45. I changed its height to 100%.

image

image

after
image

@THEb0nny THEb0nny changed the title Pxt core bump 9.1.14 Pxt core bump 9.1.1x Sep 24, 2023
Got rid of queryArr and infoArr, which I created to support the color sensor in the RawRgb mode in the simulator.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Sep 26, 2023

Got rid of queryArr() and infoArr(), which I created to support the color sensor in the RawRgb mode in the simulator.
Now the normal query() and info() methods return an array of values.
For normal modes I delivered a value of zero.

image

Revert automation extension.
@THEb0nny
Copy link
Contributor Author

I decided to move the change to return the pxt-automation extension to this pull.
#1034

@THEb0nny THEb0nny changed the title Pxt core bump 9.1.1x Pxt core bump 9.1.1x and more Sep 26, 2023
Move the status indicator to a separate group. It was in a button group, but according to the ev3 manual it is not a button, so I created a separate group for it and output the code to a separate file. It's logical.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Oct 4, 2023

Move the status indicator to a separate group. It was in a button group, but according to the ev3 manual it is not a button, so I created a separate group for it and output the code to a separate file. It's logical.
image

exitProgram has been moved from buttons to the program group.
The i2c sensors will work when the program starts. Before this, the i2c sensor started working only when other sensors were reconnected, calling detectDevices() again.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Oct 16, 2023

The latest commit allows i2c sensors to work when the program starts. Before this, the i2c sensor started working only when other sensors were reconnected, calling detectDevices() again.
I was poking around in the code and noticed that the i2c sensor was initially detected, but later, line 288 sensorInfo.sensor = sensorInfo.sensors.filter(s => s._IICId() == sensorInfo.iicid)[0]; showed that nothing was found.
This raised a question for me, how could this be, sensorInfo.iicid gave what I expected, and _IICId() is a method of the IICSensor class of the sensor, which was added to the Sensor class just for it.
I came up with the idea of setting a large delay of about 1000 ms before detectDevices(). And it worked. The sensor was eventually activated. As a result, I set 900 ms for devPoller = new Poller, less does not give results. Also in the poll method of the Poller class you need to add pause(this.interval) at the beginning.
The changes are based on what pelikhan did.
#955

I tested on the HT Color sensor v2 by implementing the following extension https://github.com/THEb0nny/HiTechnic-Color-Sensor-v2
Including the sensor works in the 1st port.
Only UART sensors do not work in the first port. The touch sensor (analog) sensor works in the first port.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Oct 17, 2023

I tested the latest changes simultaneously with 2 color sensors (2 and 3 ports), 4 port ht color sensor, 1 port touch sensor.

forever(function () {
    brick.clearScreen();
    brick.showValue("T", sensors.touch1.isPressed() ? 1 : 0, 1);
    //brick.showValue("1RR", sensors.color1.light(LightIntensityMode.ReflectedRaw), 1);
    brick.showValue("2RR", sensors.color2.light(LightIntensityMode.ReflectedRaw), 2);
    brick.showValue("3RR", sensors.color3.light(LightIntensityMode.ReflectedRaw), 3);
    brick.showValue("C", sensors.htColor4.getAll()[0], 4);
    brick.showValue("R", sensors.htColor4.getAll()[1], 5);
    brick.showValue("G", sensors.htColor4.getAll()[2], 6);
    brick.showValue("B", sensors.htColor4.getAll()[3], 7);
    brick.showValue("W", sensors.htColor4.getAll()[4], 8);
    pause(20);
})

@THEb0nny
Copy link
Contributor Author

The color-for-separator-lego-ana-microsoft-logos commit changes the color of the logo separator in the header from white to gray.

image
image

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Nov 2, 2023

@jwunderl can you see all the changes?

Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pr, for now separate out approved extension to another pr (targetconfig is served live besides a ~24hour cache anyway so it's not release blocking / merging that on it's own will be enough) and I can merge it in / bump it tomorrow am

targetconfig.json Outdated Show resolved Hide resolved
targetconfig.json Outdated Show resolved Hide resolved
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Nov 3, 2023

@jwunderl I have a question: what was the sudden jump in pxt-core versions to 9.3? 9.3.3 is this the latest build and can it be specified?

@THEb0nny THEb0nny requested a review from jwunderl November 3, 2023 06:50
@jwunderl
Copy link
Member

jwunderl commented Nov 3, 2023

When we do major releases we typically create stable branches that lock down a minor version to allow us to port hotfixes to the branch; I'm not certain why 9.2 was skipped over with just a few tags right away, but looks like there is both a stable9.1 and stable9.2 branch so possibly both being used / we did have a few releases last week (xbox app, minecraft) so that's where the bump came from.

With that said, nothing huge / semver minor bump required in them from the looks of it, can see the last dozen or so commits here https://github.com/microsoft/pxt/commits/master

@jwunderl jwunderl merged commit 92ff131 into microsoft:master Nov 3, 2023
2 checks passed
@THEb0nny THEb0nny deleted the pxt-core-bump-9-1-11 branch November 3, 2023 18:30
@jwunderl jwunderl mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants