-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pxt core bump 9.1.1x and more #1038
Conversation
Timely update of the pxt-core version to support the project.
Got rid of queryArr and infoArr, which I created to support the color sensor in the RawRgb mode in the simulator.
Revert automation extension.
I decided to move the change to return the pxt-automation extension to this pull. |
Move the status indicator to a separate group. It was in a button group, but according to the ev3 manual it is not a button, so I created a separate group for it and output the code to a separate file. It's logical.
exitProgram has been moved from buttons to the program group.
The i2c sensors will work when the program starts. Before this, the i2c sensor started working only when other sensors were reconnected, calling detectDevices() again.
The latest commit allows i2c sensors to work when the program starts. Before this, the i2c sensor started working only when other sensors were reconnected, calling detectDevices() again. I tested on the HT Color sensor v2 by implementing the following extension https://github.com/THEb0nny/HiTechnic-Color-Sensor-v2 |
I tested the latest changes simultaneously with 2 color sensors (2 and 3 ports), 4 port ht color sensor, 1 port touch sensor.
|
@jwunderl can you see all the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pr, for now separate out approved extension to another pr (targetconfig is served live besides a ~24hour cache anyway so it's not release blocking / merging that on it's own will be enough) and I can merge it in / bump it tomorrow am
@jwunderl I have a question: what was the sudden jump in pxt-core versions to 9.3? 9.3.3 is this the latest build and can it be specified? |
When we do major releases we typically create stable branches that lock down a minor version to allow us to port hotfixes to the branch; I'm not certain why 9.2 was skipped over with just a few tags right away, but looks like there is both a stable9.1 and stable9.2 branch so possibly both being used / we did have a few releases last week (xbox app, minecraft) so that's where the bump came from. With that said, nothing huge / semver minor bump required in them from the looks of it, can see the last dozen or so commits here https://github.com/microsoft/pxt/commits/master |
Increased pxt-core version for timely support.
Additionally, there is a change in the programming language switch.
A visual bug could appear at different scales.
#editortoggle.ui.grid.padded it may be a little more than 45 in height, but the background fill element (.ui.item.toggle.dropdown-attached) is always 45. I changed its height to 100%.
after