Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't recover sprite clipping through wall #2960

Open
livcheerful opened this issue Jan 22, 2021 · 3 comments · May be fixed by microsoft/pxt-common-packages#1222
Open

Can't recover sprite clipping through wall #2960

livcheerful opened this issue Jan 22, 2021 · 3 comments · May be fixed by microsoft/pxt-common-packages#1222
Assignees
@jwunderl
Labels
bug Something isn't working p2 physics

Comments

@livcheerful
Copy link
Contributor

Describe the bug
My sprite started off inside a sea of wall, but I can't move outside of the walls anymore. And when I use left/right controls, sometimes it goes the opposite way

clip

Expected behavior
I should be able to get out of the walls

(using beta)
Desktop (please complete the following information):

  • OS: ChromeOS
  • Browser Chrome86
@jwunderl jwunderl added bug Something isn't working p2 physics labels Jan 22, 2021
@jwunderl jwunderl self-assigned this Jan 22, 2021
@jwunderl
Copy link
Member

jwunderl commented Jan 22, 2021 •
edited
Loading

AHH this one's actually not a regression, the issue is that the sprite is being made before the tilemap so it's only clipping once the tilemap is set (if you move the tilemap to the top or do a set position on the sprite after the tilemap is created things will work)

Should probably make it so set wall on and set tilemap both run through all sprites and try to resolve overlaps, but wouldn't block release on it. (I'll see about doing that now, maybe we can sneak it in)

@livcheerful
Copy link
Contributor Author

ooooooooooooooooooh okay makes sense no pressure! I just thought it was related to the physics changes yesterday D: rip

@jwunderl
Copy link
Member

I guess no
image
for you

@jwunderl jwunderl linked a pull request Jan 22, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwunderl jwunderl

Labels
bug Something isn't working p2 physics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for clipping when walls change microsoft/pxt-common-packages
4 participants
@jwunderl @abchatra @riknoll @livcheerful