Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to tag released commits? #1155

Closed
take-cheeze opened this issue Nov 14, 2023 · 2 comments · Fixed by #1156
Closed

Is it possible to tag released commits? #1155

take-cheeze opened this issue Nov 14, 2023 · 2 comments · Fixed by #1156

Comments

@take-cheeze
Copy link
Contributor

I've seen there is many releases in pypi: https://pypi.org/project/onnxscript/#history
But there is no tags that corrensponds to the commit. It might be confusing to find what version is causing the problem.
Is it possible to tag this repo's commit when pypi publishing succeeded?
@justinchuby
Copy link
Collaborator

We currently don't tag dev releases. The tags will be created for official releases. Do you feel strongly we should do one way or another?

@take-cheeze take-cheeze mentioned this issue Nov 15, 2023
Merged
@take-cheeze
Copy link
Contributor Author

I've just added some dev feature to reference commit tree URL: #1156

justinchuby added a commit that referenced this issue Nov 22, 2023
@take-cheeze @justinchuby
Add more URLs to package (#1156)
77ef131 
Sorry to add "complex logic in setup.py".
Though it's a development feature

closes #1155

I'm specifying `url` since it's not allowed in pyproject.toml:
pypa/packaging-problems#606

---------

Co-authored-by: Justin Chu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more URLs to package take-cheeze/onnxscript
2 participants
@take-cheeze @justinchuby