From d203b1891718dbd46aee54e8c36c7fcd21b7e601 Mon Sep 17 00:00:00 2001 From: edgchen1 <18449977+edgchen1@users.noreply.github.com> Date: Tue, 9 Jul 2024 20:22:44 -0700 Subject: [PATCH 1/2] Pass a list of files instead of path separator-delimited string to project.files(). --- java/build-android.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/build-android.gradle b/java/build-android.gradle index afbad9f03d08d..fd22fa27e8db9 100644 --- a/java/build-android.gradle +++ b/java/build-android.gradle @@ -105,7 +105,7 @@ task sourcesJar(type: Jar) { task javadoc(type: Javadoc) { source = android.sourceSets.main.java.srcDirs - classpath += project.files(android.getBootClasspath().join(File.pathSeparator)) + classpath += project.files(android.getBootClasspath()) } task javadocJar(type: Jar, dependsOn: javadoc) { From 57c63431616d60b81b9e604586370649dffddea0 Mon Sep 17 00:00:00 2001 From: Edward Chen <18449977+edgchen1@users.noreply.github.com> Date: Thu, 11 Jul 2024 09:45:51 -0700 Subject: [PATCH 2/2] Check for host being Windows when using fallback patch program. --- cmake/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index a9b0dfb30cc4e..7761c20c5ac38 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -551,7 +551,7 @@ if(NOT WIN32 AND NOT CMAKE_SYSTEM_NAME STREQUAL "Android") endif() find_package(Patch) -if (WIN32 AND NOT Patch_FOUND) +if (CMAKE_HOST_WIN32 AND NOT Patch_FOUND) # work around CI machines missing patch from the git install by falling back to the binary in this repo. # replicate what happens in https://github.com/Kitware/CMake/blob/master/Modules/FindPatch.cmake but without # the hardcoded suffixes in the path to the patch binary.