Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExportModelForInferencing should use External Data if Necessary #23041

Open
Whadup opened this issue Dec 6, 2024 · 1 comment
Open

ExportModelForInferencing should use External Data if Necessary #23041

Whadup opened this issue Dec 6, 2024 · 1 comment
Labels
stale issues that have not been addressed in a while; categorized by a bot

Comments

@Whadup
Copy link

Whadup commented Dec 6, 2024

When storing large models, the export routine should decide to use external data.

Currently, external data is only used when the checkpoint is already using external data.

if (state_->has_external_data) {

However, exporting Model plus Checkpoint might make usage of external data necessary, as the result is larger than 2gb, while both model and checkpoint on their own might be smaller than 2gb.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@github-actions github-actions bot added the stale issues that have not been addressed in a while; categorized by a bot label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

No branches or pull requests

1 participant