Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] [npm/nodejs] Failed to download the binaries: 404 Not Found #22877

Closed
lucyknada opened this issue Nov 18, 2024 · 6 comments · Fixed by #22984
Closed

[cuda] [npm/nodejs] Failed to download the binaries: 404 Not Found #22877

lucyknada opened this issue Nov 18, 2024 · 6 comments · Fixed by #22984
Assignees
Labels
documentation improvements or additions to documentation; typically submitted using template ep:CUDA issues related to the CUDA execution provider platform:web issues related to ONNX Runtime web; typically submitted using template

Comments

@lucyknada
Copy link

the readme tells you to use

npm install onnxruntime-node --onnxruntime-node-install-cuda=v12

to pull in the cuda binaries for linux x64; it tries to download:

https://github.com/microsoft/onnxruntime/releases/download/v1.20.0/onnxruntime-linux-x64-gpu-cuda12-1.20.0.tgz

which indeed does not exist, what does exist is:

 onnxruntime-linux-x64-gpu-1.20.0.tgz 

but there is no way to pass an empty string to --onnxruntime-node-install so that it assembles the right URL.

@github-actions github-actions bot added ep:CUDA issues related to the CUDA execution provider platform:web issues related to ONNX Runtime web; typically submitted using template labels Nov 18, 2024
@lucyknada
Copy link
Author

after looking at the code --onnxruntime-node-install-cuda just as is will make this work; however maybe the docs/readme should be updated?

@skottmckay
Copy link
Contributor

Which docs specifically?

@lucyknada
Copy link
Author

https://github.com/microsoft/onnxruntime/blob/main/js/node/README.md

which gets pulled into the readme over at: https://www.npmjs.com/package/onnxruntime-node

see the bottom note that mentions v12 (which is non existent now)

@skottmckay skottmckay added the documentation improvements or additions to documentation; typically submitted using template label Nov 26, 2024
@skottmckay
Copy link
Contributor

@fs-eire should we update the install script if we're not producing CUDA 11 and 12 packages to remove the option to choose?

@fs-eire
Copy link
Contributor

fs-eire commented Nov 26, 2024

Background: There is a max size limit for NPM package, so it is impossible to include CUDA binaries inside onnxruntime-node. I made this install script for onnxruntime-node to allow users to download the CUDA binaries from github.

Before 1.18.x, there are both onnxruntime-win-x64-gpu-1.18.0.zip and onnxruntime-win-x64-gpu-cuda12-1.18.0.zip in the github release assets, containing the CUDA v11 bits and CUDA v12 bits.

  • --onnxruntime-node-install-cuda[=v11] will download file https://github.com/microsoft/onnxruntime/releases/download/v{VERSION}/onnxruntime-win-x64-gpu-{VERSION}.zip
  • --onnxruntime-node-install-cuda=v12 will download file https://github.com/microsoft/onnxruntime/releases/download/v{VERSION}/onnxruntime-win-x64-gpu-cuda12-{VERSION}.zip

Since 1.19.x, CUDA v12 became default and the onnxruntime-win-x64-gpu-cuda12-{VERSION}.zip is no longer provided in Github release assets.

I can make a change in the installation script to fix it for CUDA v12. However, it may be difficult for CUDA v11 since there is no public assets.

@fs-eire
Copy link
Contributor

fs-eire commented Nov 26, 2024

I will make a change to fix the installation script for cuda v12.

@fs-eire fs-eire closed this as completed in d3bc318 Dec 4, 2024
ankitm3k pushed a commit to intel/onnxruntime that referenced this issue Dec 11, 2024
…oft#22984)

### Description

This PR updates installation script to fix it for CUDA v12. However, it
may be difficult for CUDA v11 since the steps are quite complicated to
automate. Added a few lines of instructions instead.

fixes microsoft#22877
ankitm3k pushed a commit to intel/onnxruntime that referenced this issue Dec 11, 2024
…oft#22984)

### Description

This PR updates installation script to fix it for CUDA v12. However, it
may be difficult for CUDA v11 since the steps are quite complicated to
automate. Added a few lines of instructions instead.

fixes microsoft#22877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation; typically submitted using template ep:CUDA issues related to the CUDA execution provider platform:web issues related to ONNX Runtime web; typically submitted using template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants