Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Support reshape and expand with 0d input and 0d output #22215

Closed
mingmingtasd opened this issue Sep 25, 2024 · 2 comments · Fixed by #22344
Closed

[WebNN EP] Support reshape and expand with 0d input and 0d output #22215

mingmingtasd opened this issue Sep 25, 2024 · 2 comments · Fixed by #22344
Labels
ep:WebNN WebNN execution provider platform:web issues related to ONNX Runtime web; typically submitted using template

Comments

@mingmingtasd
Copy link
Contributor

Describe the issue

A scalar input to a scalar output should be valid nop for reshape and expand.

To reproduce

Run onnx model with reshape or expand, the input and output are both 0d scalar on WebNN EP.

Urgency

No response

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

a47254e

Execution Provider

Other / Unknown
@mingmingtasd mingmingtasd added the platform:web issues related to ONNX Runtime web; typically submitted using template label Sep 25, 2024
@github-actions github-actions bot added the ep:WebNN WebNN execution provider label Sep 25, 2024
@mingmingtasd
Copy link
Contributor Author

@fdwr @Honry

@mingmingtasd mingmingtasd mentioned this issue Sep 25, 2024
Merged
@fdwr
Copy link
Contributor

fdwr commented Oct 2, 2024

Related Chromium issue: https://issues.chromium.org/issues/369432531

Honry added a commit to Honry/onnxruntime that referenced this issue Oct 8, 2024
@Honry
[WebNN EP] Allow 0D input/output for Reshape and Expand
3a75211 
- Allows Expand input be a scalar
- Allows Reshape input be a scalar
- Allows Reshape to a scalar

Fixed microsoft#22215
@Honry Honry mentioned this issue Oct 8, 2024
Merged
Honry added a commit to Honry/onnxruntime that referenced this issue Oct 23, 2024
@Honry
[WebNN EP] Allow 0D input/output for Reshape and Expand
1fbe809 
- Allows Expand input be a scalar
- Allows Reshape input be a scalar
- Allows Reshape to a scalar

Fixed microsoft#22215
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this issue Nov 19, 2024
@Honry @fdwr
[WebNN EP] Allow 0D input/output for Reshape and Expand (microsoft#22344
d21389b 
)

- Allows Expand input be a scalar
- Allows Reshape input be a scalar
- Allows Reshape to a scalar

Fixed microsoft#22215

---------

Co-authored-by: Dwayne Robinson <[email protected]>
ankitm3k pushed a commit to intel/onnxruntime that referenced this issue Dec 11, 2024
@Honry @fdwr @ankitm3k
[WebNN EP] Allow 0D input/output for Reshape and Expand (microsoft#22344
e809f42 
)

- Allows Expand input be a scalar
- Allows Reshape input be a scalar
- Allows Reshape to a scalar

Fixed microsoft#22215

---------

Co-authored-by: Dwayne Robinson <[email protected]>
ankitm3k pushed a commit to intel/onnxruntime that referenced this issue Dec 11, 2024
@Honry @fdwr @ankitm3k
[WebNN EP] Allow 0D input/output for Reshape and Expand (microsoft#22344
3711142 
)

- Allows Expand input be a scalar
- Allows Reshape input be a scalar
- Allows Reshape to a scalar

Fixed microsoft#22215

---------

Co-authored-by: Dwayne Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider platform:web issues related to ONNX Runtime web; typically submitted using template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WebNN EP] Allow 0D input/output for Reshape and Expand Honry/onnxruntime
2 participants
@fdwr @mingmingtasd