Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why ONNX Runtime Dlls are not Signed by Microsoft #21775

Closed
coolsanil opened this issue Aug 16, 2024 · 0 comments · Fixed by #21854
Closed

Why ONNX Runtime Dlls are not Signed by Microsoft #21775

coolsanil opened this issue Aug 16, 2024 · 0 comments · Fixed by #21854
Assignees
@mszhanyi
Labels
build build issues; typically submitted using template .NET Pull requests that update .net code

Comments

@coolsanil
Copy link

coolsanil commented Aug 16, 2024 •
edited
Loading

Describe the issue

Microsoft has not signed OnnxRuntime.dll in Microsoft.ML.OnnxRuntime nuget package with version 1.18.1

To reproduce

Install the Microsoft.ML.OnnxRuntime nuget package, version 1.18. All of the DLL included here have been signed by Microsoft.Now update that package with 1.18.1, and you can see that the DLL have not been signed by Microsoft.

Urgency

As onnxruntime.dll is not signed by Microsoft, it leads to an upgrade issue

Platform

Windows

OS Version

Windows 11 23H2

ONNX Runtime Installation

Released Package

ONNX Runtime Version or Commit ID

1.18.1

ONNX Runtime API

C++

Architecture

X64

Execution Provider

Default CPU

Execution Provider Library Version

No response
@github-actions github-actions bot added the .NET Pull requests that update .net code label Aug 16, 2024
@yuslepukhin yuslepukhin added the build build issues; typically submitted using template label Aug 22, 2024
@mszhanyi mszhanyi mentioned this issue Aug 26, 2024
Merged
mszhanyi added a commit that referenced this issue Aug 26, 2024
@mszhanyi
sign native dll with correct cert (#21854)
2877de7 
### Description
Fixed #21775



### Motivation and Context
The dlls should be signed with Keycode CP-230012.
The default is the test code sign.
prathikr pushed a commit that referenced this issue Aug 26, 2024
@mszhanyi @prathikr
sign native dll with correct cert (#21854)
7ca73dc 
### Description
Fixed #21775



### Motivation and Context
The dlls should be signed with Keycode CP-230012.
The default is the test code sign.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mszhanyi mszhanyi

Labels
build build issues; typically submitted using template .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sign native dll with correct cert microsoft/onnxruntime
4 participants
@yuslepukhin @mszhanyi @ZhangY-MSFT @coolsanil