Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnnxRuntime nuget package uses build and not buildTransitive #19676

Open
ericstj opened this issue Feb 27, 2024 · 1 comment
Open

OnnxRuntime nuget package uses build and not buildTransitive #19676

ericstj opened this issue Feb 27, 2024 · 1 comment
Labels
.NET Pull requests that update .net code stale issues that have not been addressed in a while; categorized by a bot

Comments

@ericstj
Copy link
Member

ericstj commented Feb 27, 2024

Describe the issue

The microsoft.ml.onnxruntime.managed package includes targets to warn the user when referencing on an unsupported architecture. Those targets will not be applied when the package is referenced transitively because they are placed in build and not buildTransitive.

<None Include="targets\netstandard\$(PackageId).targets"
PackagePath="build\netstandard2.0\$(PackageId).targets"
Pack="true"
Visible="false"
/>

Probably those should be copied to buildTransitive https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets

Here's a similar issue I noticed with LightGBM: microsoft/LightGBM#6344

To reproduce

See attached project
onnxRuntime-buildTransitiveSample.zip

Note that the targets are not included when running in the app - which specifies a platformtarget of Itanium and should trigger the Error in those targtes.

Urgency

Probably not too urgent since OnnxRuntime supports most architectures and the warning won't likely be hit, but I wanted to raise this since I noticed the problem.

Platform

Windows

OS Version

11 22H2

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

1.17.1

ONNX Runtime API

C#

Architecture

X64

Execution Provider

Default CPU

Execution Provider Library Version

No response

@petermcaughan petermcaughan added the .NET Pull requests that update .net code label Feb 27, 2024
Copy link
Contributor

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@github-actions github-actions bot added the stale issues that have not been addressed in a while; categorized by a bot label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

No branches or pull requests

2 participants