[Build] Syntax errors in core/providers/dml/dml_provider_factory.h building with --build_java and --use_dml #19656

CaelumF · 2024-02-26T21:22:45Z

Describe the issue

Build fails with syntax errors when building with --build_java and --use_dml.

This appears to be due to the java native code being C that depends on header files which contain C++-only code even when ifdef __cplusplus is false.

Use case

I want to make a multiplatform desktop application that works out of the box and uses onnx for local hardware accelerated inference. Jetpack Compose Desktop is a good solution for this, which along with Conveyor makes distribution easy and is arguably a better solution than Electron for multiplatform desktop apps (pros: get to use Kotlin, the JVM is nice for multi OS interop and actually has lower overhead than Electron, enables more ergonomic multi-threading, and is much less prone to exposing OS APIs to XSS attacks. cons: less mature)

Onnx is great for this use case, for Mac it's working out of the box, Linux with cuda or rocm works when it's installed separately and the env vars point to it, which is expected for Linux users, and Windows could easily work out of the box regardless of hardware using DML, though for now seemingly has to fall back to CPU until this is fixed

Other details

I have tried a bit of converting dml_provider_factory.h to be C compatible, but it seems there are other DML files then which are problematic. Maybe the play is to make the C files under java/src/main/native compiled as C++? (I did try this a bit as well, though I'm not very familiar with C/C++ build tools, and the C code does not actually seem to be fully valid C++ code)

Happy to pair up on this, though I have little experience with C and C++ so I won't be able to do much on my own.

Urgency

Currently rare but high potential use case. Fixing would be immediately beneficial

Target platform

Java, Windows, DML, all arches

Build script

(rel 1.17.1 checked out)
(I also manually placed DirectML.lib files into build/Windows/packages/Microsoft.AI.DirectML.1.13.1/bin/* from a .nupkg because they were missing from the automatically downloaded one 🤷 )
\build.bat --config Debug --cmake_generator "Visual Studio 17 2022" --build_java --use_dml --skip_tests --skip_submodule_sync --compile_no_warning_as_error

(also tried with Release and RelWithDebInfo)

Error / output

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\Debug\onnxruntime.dl
  l
  Building Custom Rule
C:/Users/Caelum/IdeaProjects/onnxruntime3/onnxruntime/cmake/CMakeLists.txt
  Ignoring COMPILE_WARNING_AS_ERROR target property and
CMAKE_COMPILE_WARNING_AS_ERROR variable.
  OrtJniUtil.c
  ai_onnxruntime_OnnxMap.c
  ai_onnxruntime_OnnxRuntime.c
  ai_onnxruntime_OnnxSequence.c
  ai_onnxruntime_OnnxSparseTensor.c
  ai_onnxruntime_OnnxTensor.c
  ai_onnxruntime_OrtAllocator.c
  ai_onnxruntime_OrtEnvironment.c
  ai_onnxruntime_OrtEnvironment_ThreadingOptions.c
  ai_onnxruntime_OrtSession.c
  ai_onnxruntime_OrtSession_RunOptions.c
  ai_onnxruntime_OrtSession_SessionOptions.c
C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(39,
25): error C2059: syntax error: ':'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(49,
27): error C2061: syntax error: identifier 'operator'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Wind
ows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(49,
27): error C2059: syntax error: ';'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(49,
35): error C2059: syntax error: '~'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(50,
27): error C2061: syntax error: identifier 'operator'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Wind
ows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(50,
27): error C2059: syntax error: ';'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(50,
35): error C2059: syntax error: '|'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(51,
27): error C2061: syntax error: identifier 'operator'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Wind
ows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(51,
27): error C2059: syntax error: ';'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(51,
35): error C2059: syntax error: '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(52,
27): error C2061: syntax error: identifier 'operator'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Wind
ows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(52,
27): error C2059: syntax error: ';'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(52,
35): error C2059: syntax error: '^'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(53,
26): error C2143: syntax error: missing '{' before '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Win
dows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(53,
26): error C2059: syntax error: '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(54,
26): error C2143: syntax error: missing '{' before '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Win
dows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(54,
26): error C2059: syntax error: '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(55,
26): error C2143: syntax error: missing '{' before '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Win
dows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(55,
26): error C2059: syntax error: '&'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(58,
3): error C2061: syntax error: identifier
'OrtDmlPerformancePreference'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnx
runtime\build\Windows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(59,
22): error C2061: syntax error: identifier 'Filter'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Window
s\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(59,
22): error C2059: syntax error: ';'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(60,
1): error C2059: syntax error: '}'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunti
me4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): error C2143: syntax error: missing ')' before '*'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Win
dows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): error C2081: 'OrtDmlDeviceOptions': name in formal parameter list
illegal [C:\Users\Caelum\IdeaProjects\onnxruntim
e3\onnxruntime\build\Windows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): warning C4431: missing type specifier - int assumed. Note: C no
longer supports default-int [C:\Users\Caelum\IdeaP
rojects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): error C2143: syntax error: missing ';' before '*'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Win
dows\Debug\onnxruntime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): error C2059: syntax error: '*'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(137
,3): error C2059: syntax error: ')'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\include\onnxruntime\core\providers\dml\dml_provider_factory.h(138
,1): error C2059: syntax error: '}'
[C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\onnxrunt
ime4j_jni.vcxproj]
  (compiling source file
'../../../java/src/main/native/ai_onnxruntime_OrtSession_SessionOptions.c')

  ai_onnxruntime_OrtTrainingSession.c
  ai_onnxruntime_OrtTrainingSession_OrtCheckpointState.c
  ai_onnxruntime_providers_OrtCUDAProviderOptions.c
  ai_onnxruntime_providers_OrtTensorRTProviderOptions.c
  Generating Code...
  onnxruntime_providers_shared.vcxproj ->
C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\Deb
  ug\onnxruntime_providers_shared.dll
  test_execution_provider.vcxproj ->
C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\build\Windows\Debug\Debug\te
  st_execution_provider.dll
Traceback (most recent call last):
  File "C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\tools\ci_build\build.py",
line 2905, in <module>
    sys.exit(main())
  File "C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\tools\ci_build\build.py",
line 2797, in main
    build_targets(args, cmake_path, build_dir, configs,
num_parallel_jobs, args.target)
  File "C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\tools\ci_build\build.py",
line 1689, in build_targets
    run_subprocess(cmd_args, env=env)
  File "C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\tools\ci_build\build.py",
line 852, in run_subprocess
    return run(*args, cwd=cwd, capture_stdout=capture_stdout,
shell=shell, env=my_env)
  File "C:\Users\Caelum\IdeaProjects\onnxruntime3\onnxruntime\tools\python\util\run.py",
line 49, in run
    completed_process = subprocess.run(
  File "C:\Python39\lib\subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['C:\\Program
Files\\CMake\\bin\\cmake.EXE', '--build',
'C:\\Users\\Caelum\\IdeaProjects\\onnxruntime3\\onnxruntime\\\\build\\Windows\\Debug',
'--config', 'Debug']' returned non-zero exit status 1.

Visual Studio Version

Community 2022 17.9.1

GCC / Compiler Version

tried with cl printing Microsoft (R) C/C++ Optimizing Compiler Version 19.38.33133 for x86 and Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27051 for x86

The text was updated successfully, but these errors were encountered:

Craigacp · 2024-02-26T22:26:47Z

I don't plan to convert the JNI code to C++ so let's try to get the DML header fixed so it's parseable as C. Looks like it doesn't like the enum being a subtype of uint_32t (as that's a C23 thing) or the operator overloading on OrtDmlDeviceFilter.

github-actions · 2024-03-28T15:01:08Z

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

Craigacp · 2024-03-28T15:20:54Z

Keep this open, it's still an issue.

@martinb35

…a C header file (#20157) ### Description The dml_provider_factory header file can't be used in C programs as it defines C++ inline operators. This PR rearranges that header file so that it looks like valid C when used from C, and also makes a couple of small modifications to the Java code so it correctly binds to the DML EP at build time. I'm having some difficulty testing it as I think it's pulling in the old version of DirectML on my computer and I can't figure out what the library loading path is in Java to make it look at the recent version I downloaded. So the test I added fails with: ``` InferenceTest > testDirectML() FAILED ai.onnxruntime.OrtException: Error code - ORT_RUNTIME_EXCEPTION - message: Exception during initialization: <path-to-ort>\onnxruntime\core\providers\dml\DmlExecutionProvider\src\AbiCustomRegistry.cpp(518)\onnxruntime.dll!00007FFF74819333: (caller: 00007FFF74793509) Exception(3) tid(4f58) 80070057 The parameter is incorrect. at app//ai.onnxruntime.OrtSession.createSession(Native Method) at app//ai.onnxruntime.OrtSession.<init>(OrtSession.java:74) at app//ai.onnxruntime.OrtEnvironment.createSession(OrtEnvironment.java:236) at app//ai.onnxruntime.OrtEnvironment.createSession(OrtEnvironment.java:221) at app//ai.onnxruntime.InferenceTest.openSessionSqueezeNet(InferenceTest.java:1961) at app//ai.onnxruntime.InferenceTest.runProvider(InferenceTest.java:665) at app//ai.onnxruntime.InferenceTest.testDirectML(InferenceTest.java:657) ``` But it does correctly compile, and this error seems very similar to other issues with the DML provider when it doesn't like a model due to the loaded library being old. The test is using the squeezenet file that's been in the repo since 2019. If someone can help me figure out how to get the right version of DML in the library path I can test it more on my end. I tried adding the folder with the new version into the system path, but I'm not very familiar with Windows' library loading behaviour. ### Motivation and Context Fixes #19656 to allow use of the DirectML EP from ORT Java. cc @martinb35

@martinb35

…a C header file (microsoft#20157) ### Description The dml_provider_factory header file can't be used in C programs as it defines C++ inline operators. This PR rearranges that header file so that it looks like valid C when used from C, and also makes a couple of small modifications to the Java code so it correctly binds to the DML EP at build time. I'm having some difficulty testing it as I think it's pulling in the old version of DirectML on my computer and I can't figure out what the library loading path is in Java to make it look at the recent version I downloaded. So the test I added fails with: ``` InferenceTest > testDirectML() FAILED ai.onnxruntime.OrtException: Error code - ORT_RUNTIME_EXCEPTION - message: Exception during initialization: <path-to-ort>\onnxruntime\core\providers\dml\DmlExecutionProvider\src\AbiCustomRegistry.cpp(518)\onnxruntime.dll!00007FFF74819333: (caller: 00007FFF74793509) Exception(3) tid(4f58) 80070057 The parameter is incorrect. at app//ai.onnxruntime.OrtSession.createSession(Native Method) at app//ai.onnxruntime.OrtSession.<init>(OrtSession.java:74) at app//ai.onnxruntime.OrtEnvironment.createSession(OrtEnvironment.java:236) at app//ai.onnxruntime.OrtEnvironment.createSession(OrtEnvironment.java:221) at app//ai.onnxruntime.InferenceTest.openSessionSqueezeNet(InferenceTest.java:1961) at app//ai.onnxruntime.InferenceTest.runProvider(InferenceTest.java:665) at app//ai.onnxruntime.InferenceTest.testDirectML(InferenceTest.java:657) ``` But it does correctly compile, and this error seems very similar to other issues with the DML provider when it doesn't like a model due to the loaded library being old. The test is using the squeezenet file that's been in the repo since 2019. If someone can help me figure out how to get the right version of DML in the library path I can test it more on my end. I tried adding the folder with the new version into the system path, but I'm not very familiar with Windows' library loading behaviour. ### Motivation and Context Fixes microsoft#19656 to allow use of the DirectML EP from ORT Java. cc @martinb35

CaelumF added the build build issues; typically submitted using template label Feb 26, 2024

CaelumF mentioned this issue Feb 26, 2024

ORT 1.17.0 Release Candidates available for testing #19236

Open

github-actions bot added the stale issues that have not been addressed in a while; categorized by a bot label Mar 28, 2024

github-actions bot removed the stale issues that have not been addressed in a while; categorized by a bot label Mar 29, 2024

Craigacp mentioned this issue Mar 30, 2024

[java][DML EP] Modifying dml_provider_factory.h so it can compile as a C header file #20157

Merged

tianleiwu closed this as completed in #20157 Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Build] Syntax errors in core/providers/dml/dml_provider_factory.h building with --build_java and --use_dml #19656

[Build] Syntax errors in core/providers/dml/dml_provider_factory.h building with --build_java and --use_dml #19656

CaelumF commented Feb 26, 2024 •

edited

Loading

Craigacp commented Feb 26, 2024

github-actions bot commented Mar 28, 2024

Craigacp commented Mar 28, 2024

[Build] Syntax errors in core/providers/dml/dml_provider_factory.h building with --build_java and --use_dml #19656

[Build] Syntax errors in core/providers/dml/dml_provider_factory.h building with --build_java and --use_dml #19656

Comments

CaelumF commented Feb 26, 2024 • edited Loading

Describe the issue

Use case

Other details

Urgency

Target platform

Build script

Error / output

Visual Studio Version

GCC / Compiler Version

Craigacp commented Feb 26, 2024

github-actions bot commented Mar 28, 2024

Craigacp commented Mar 28, 2024

CaelumF commented Feb 26, 2024 •

edited

Loading