Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Perf decrease #19523

Open
P0man opened this issue Feb 14, 2024 · 3 comments
Open

[Performance] Perf decrease #19523

P0man opened this issue Feb 14, 2024 · 3 comments
Labels
performance issues related to performance regressions stale issues that have not been addressed in a while; categorized by a bot

Comments

@P0man
Copy link

P0man commented Feb 14, 2024

Describe the issue

I run cpu model (can't provide it) with different versions of onnxruntime (builded from source). v1.11.1, v1.14.0, v1.17.0.
And timings of inference are

version
mean min max q95

1.11.1
328970 303519 367536 348662

1.14.0
351867 338643 401872 382355

1.17.0
348458 328082 380977 376152

Inference c++ code is the same.
So I don't really get whats the problem with performance decreasing with new versions of onnxruntime

To reproduce

Sorry cannot share model

Urgency

No response

Platform

Linux

OS Version

rh8.8

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

1.11.0; 1.14.0; 1.17.0

ONNX Runtime API

C++

Architecture

X64

Execution Provider

Default CPU

Execution Provider Library Version

No response

Model File

No response

Is this a quantized model?

No

@tianleiwu
Copy link
Contributor

Try profiling: https://onnxruntime.ai/docs/performance/tune-performance/profiling-tools.html.

Report back if you have some findings (like some operators or part takes longer in 1.11 vs 1.17).

@skottmckay
Copy link
Contributor

Also not clear how exactly you're measuring performance and whether external things are being included in the timing.

  • run the model once as a warmup.
    • this will initialize a lot of infrastructure so the following calls to run are faster
    • measure the calls after this
  • measure only the call to run
    • inputs should not be allocated/populated within the measurement
    • no print statements or anything else should be in the measurement
  • make sure you're using a high resolution timer
    • what is best depends on the platform/performance measurement code

@sophies927 sophies927 added the performance issues related to performance regressions label Feb 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@github-actions github-actions bot added the stale issues that have not been addressed in a while; categorized by a bot label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance issues related to performance regressions stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

No branches or pull requests

4 participants