Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] ORT 1.17.0 contributions list is incomplete #19444

Closed
sophies927 opened this issue Feb 6, 2024 · 5 comments
Closed

[Documentation] ORT 1.17.0 contributions list is incomplete #19444

sophies927 opened this issue Feb 6, 2024 · 5 comments
Labels
documentation improvements or additions to documentation; typically submitted using template release:1.17.0

Comments

@sophies927
Copy link
Contributor

Describe the documentation issue

The current list of contributions from the recent ORT 1.17.0 release is incomplete (e.g., it does not include contributions made via forked repos). Here is the complete list of commits from this release period, and here is the incomplete list of contributors used to generate the contributions section. For example, I (@sophies927) made 4 contributions during the release period but do not show up on this list b/c they were made via a forked repo.

Other reasons why your contributions may not be reflected: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-profile/managing-contribution-settings-on-your-profile/why-are-my-contributions-not-showing-up-on-my-profile#commits

We are currently working on resolving this issue, but in the meantime, please let us know if you made a contribution that is not reflected in the contributions list, and we will update to make sure all ONNX Runtime contributors are getting credit for their hard work on the ORT 1.17 release!

Page / URL

https://github.com/microsoft/onnxruntime/releases/tag/v1.17.0

@sophies927 sophies927 added the documentation improvements or additions to documentation; typically submitted using template label Feb 6, 2024
@sophies927 sophies927 pinned this issue Feb 6, 2024
@NickLucche
Copy link
Contributor

Hey, I contributed to this merged PR #17726, also from a forked repo. Not sure if this should appear in the contributions, my apologies if that's not the case!

@sophies927
Copy link
Contributor Author

Hey, I contributed to this merged PR #17726, also from a forked repo. Not sure if this should appear in the contributions, my apologies if that's not the case!

Thanks so much for your contribution - your name should definitely appear in the list! Just updated https://github.com/microsoft/onnxruntime/releases/tag/v1.17.0 to include you

@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 16, 2024

@sophies927, A simple way is like the following:
git log origin/rel-1.16.0..origin/rel-1.17.0 > commits.txt
Then have a script to do statistics of author and co-author.

Another command could get author statistics directly (may not include co-author; remove -e to exclude email):
git shortlog -e -s -n origin/rel-1.16.0..origin/rel-1.17.0

@sophies927
Copy link
Contributor Author

@sophies927, A simple way is to like the following: git log --since 08/20/2023 --until 01/16/2024 > commits.txt

Then have a script to do statistics of author and co-author. Note that cherry-picks are ignored (May need adjust if needed). The dates are for the day that cut the branches of 1.16 and 1.17 (You may change it to commit ID range to be more accurate like this).

Thanks @tianleiwu I'll try that out!

@sophies927
Copy link
Contributor Author

I fixed the issue, so the contributors list for the 1.17.0 release should be complete, and I am going to close this issue.

@sophies927 sophies927 unpinned this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation; typically submitted using template release:1.17.0
Projects
None yet
Development

No branches or pull requests

3 participants