Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Concat should be a no-op for less than 2 tensor inputs #18918

Closed
DeltaEpsilon7787 opened this issue Dec 24, 2023 · 1 comment
Closed

[Performance] Concat should be a no-op for less than 2 tensor inputs #18918

DeltaEpsilon7787 opened this issue Dec 24, 2023 · 1 comment

Comments

@DeltaEpsilon7787
Copy link

Describe the issue

If Concat operator is only supplied with a single input, the output will always be the same as the input, but currently it is doing an unnecessary copy which may be very expensive for larger tensors.

image

To reproduce

N/A

Urgency

No response

Platform

Other / Unknown

OS Version

N/A

ONNX Runtime Installation

Released Package

ONNX Runtime Version or Commit ID

1.16.3

ONNX Runtime API

Other / Unknown

Architecture

Other / Unknown

Execution Provider

Other / Unknown

Execution Provider Library Version

No response

Model File

No response

Is this a quantized model?

Unknown
@DeltaEpsilon7787 DeltaEpsilon7787 mentioned this issue Dec 24, 2023
Open
@xadupre
Copy link
Member

xadupre commented Jun 19, 2024

This will be fixed in sklearn-onnx.

@xadupre xadupre closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DeltaEpsilon7787 @xadupre