Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] WebGPU has conformance regression due to introduction of FusedConv #18297

Closed
gyagp opened this issue Nov 6, 2023 · 2 comments · Fixed by #18388
Closed

[Web] WebGPU has conformance regression due to introduction of FusedConv #18297

gyagp opened this issue Nov 6, 2023 · 2 comments · Fixed by #18388
Assignees
@satyajandhyala
Labels
platform:web issues related to ONNX Runtime web; typically submitted using template

Comments

@gyagp
Copy link

gyagp commented Nov 6, 2023

Describe the issue

Due to PR below, some models (like mobilenetv2-12 and detr-resnet-50) have conformance regression

commit a2e9ba7 (HEAD -> main)
Author: satyajandhyala [email protected]
Date: Wed Nov 1 15:34:51 2023 -0700

[JS/Web]Added FusedConv. (#17766)

To reproduce

Urgency

No response

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

a2e9ba7

Execution Provider

'webgpu' (WebGPU)
@gyagp gyagp added the platform:web issues related to ONNX Runtime web; typically submitted using template label Nov 6, 2023
@gyagp
Copy link
Author

gyagp commented Nov 6, 2023

@satyajandhyala, could you please take a look?

@satyajandhyala satyajandhyala self-assigned this Nov 7, 2023
@qjia7 qjia7 mentioned this issue Nov 10, 2023
Merged
@qjia7
Copy link
Contributor

qjia7 commented Nov 10, 2023

Provide a fix here #18388.

guschmue pushed a commit that referenced this issue Nov 10, 2023
@qjia7
[js/webgpu] Fix conv2d with activation (#18388)
28c23ae 
### Description
Fix #18297

With PR #17766, conv2d activation in mobilenetv2-12 will not be empty.
However, activation is not supported yet in
[biasActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/3rd-party/activation_util.ts#L48C14-L48C36).
This PR makes all places unify to use
[getActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/fuse-utils.ts#L13)
to fix this issue.
@satyajandhyala satyajandhyala mentioned this issue Nov 10, 2023
Open
kleiti pushed a commit to kleiti/onnxruntime that referenced this issue Mar 22, 2024
@qjia7 @kleiti
[js/webgpu] Fix conv2d with activation (microsoft#18388)
8c988b0 
### Description
Fix microsoft#18297

With PR microsoft#17766, conv2d activation in mobilenetv2-12 will not be empty.
However, activation is not supported yet in
[biasActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/3rd-party/activation_util.ts#L48C14-L48C36).
This PR makes all places unify to use
[getActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/fuse-utils.ts#L13)
to fix this issue.
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this issue May 9, 2024
@qjia7
[js/webgpu] Fix conv2d with activation (microsoft#18388)
153fcbb 
### Description
Fix microsoft#18297

With PR microsoft#17766, conv2d activation in mobilenetv2-12 will not be empty.
However, activation is not supported yet in
[biasActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/3rd-party/activation_util.ts#L48C14-L48C36).
This PR makes all places unify to use
[getActivationSnippet](https://github.com/microsoft/onnxruntime/blob/main/js/web/lib/wasm/jsep/webgpu/ops/fuse-utils.ts#L13)
to fix this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satyajandhyala satyajandhyala

Labels
platform:web issues related to ONNX Runtime web; typically submitted using template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[js/webgpu] Fix conv2d with activation qjia7/onnxruntime
3 participants
@gyagp @qjia7 @satyajandhyala