Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compute kernel for StringConcat #17595

Closed
liqunfu opened this issue Sep 18, 2023 · 0 comments · Fixed by #17994
Closed

Add compute kernel for StringConcat #17595

liqunfu opened this issue Sep 18, 2023 · 0 comments · Fixed by #17994
Labels
feature request request for unsupported feature or enhancement
Milestone
1.17

Comments

@liqunfu
Copy link
Contributor

liqunfu commented Sep 18, 2023

Describe the feature request

StringConcat has been added to ONNX 1.15.0 (onnx/onnx#5350). Need to implement compute kernel once ONNX 1.15.0 is in ORT (#17125).
This issue shall include re-enable test of StringConcat op at
onnxruntime/test/testdata/onnx_backend_test_series_filters.jsonc (line 236)

Describe scenario use case

onnx_test_runner shal pass ONNX test cases for the op
@liqunfu liqunfu added the feature request request for unsupported feature or enhancement label Sep 18, 2023
@liqunfu liqunfu added this to the 1.17 milestone Sep 18, 2023
@adityagoel4512 adityagoel4512 mentioned this issue Oct 17, 2023
Merged
yuslepukhin pushed a commit that referenced this issue Jan 11, 2024
@adityagoel4512
String concat operator (#17994)
4694edc 
### Description
<!-- Describe your changes. -->



### Motivation and Context
Closes #17595.

---------

Signed-off-by: Aditya Goel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request request for unsupported feature or enhancement
Projects
None yet
Milestone
1.17
Development

Successfully merging a pull request may close this issue.

String concat operator adityagoel4512/onnxruntime
1 participant
@liqunfu