From e469de65f5eab2089b6273e7acc5e37bd645bd89 Mon Sep 17 00:00:00 2001 From: Hector Li Date: Thu, 7 Dec 2023 08:42:25 -0800 Subject: [PATCH] Re-enable Sign op int64 test for QNN CPU test (#18734) ### Description Re-enable Sign op int64 test for QNN CPU test --- onnxruntime/test/providers/cpu/math/sign_test.cc | 3 +-- onnxruntime/test/providers/cpu/nn/conv_op_test.cc | 8 -------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/onnxruntime/test/providers/cpu/math/sign_test.cc b/onnxruntime/test/providers/cpu/math/sign_test.cc index 15b3f40faa791..a01c2b26ea8b5 100644 --- a/onnxruntime/test/providers/cpu/math/sign_test.cc +++ b/onnxruntime/test/providers/cpu/math/sign_test.cc @@ -140,8 +140,7 @@ TEST(MathOpTest, Sign_int64) { std::vector output; TestImpl(input.cbegin(), input.cend(), std::back_inserter(output)); test.AddOutput("output", input_dims, output); - // TODO: QNN execute error, need further investigation - test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider, kQnnExecutionProvider}); + test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider}); } TEST(MathOpTest, Sign_float) { diff --git a/onnxruntime/test/providers/cpu/nn/conv_op_test.cc b/onnxruntime/test/providers/cpu/nn/conv_op_test.cc index 5103aed50b152..dede278b7274f 100644 --- a/onnxruntime/test/providers/cpu/nn/conv_op_test.cc +++ b/onnxruntime/test/providers/cpu/nn/conv_op_test.cc @@ -63,14 +63,6 @@ void TestConvOp(const ConvOpAndTestAttributes& attributes, // QNN SDK 2.10.0 has a bug that breaks support for dynamic bias inputs. excluded_providers.insert(kQnnExecutionProvider); - // TODO: Enable QNN EP when bug with QNN SDK 2.10.0 is fixed: - /* - // QNN have issue with dynamic weight, auto pad with SAME_UPPER, SAME_LOWER - if (!weight_is_initializer || attributes.auto_pad == "SAME_UPPER" || attributes.auto_pad == "SAME_LOWER") { - excluded_providers.insert(kQnnExecutionProvider); - } - */ - test.Run(expect_result, err_str, excluded_providers); }