From e3f9e9f261f82fc0ba8486be87d14d6e60494cdb Mon Sep 17 00:00:00 2001 From: Maxwell Collins Date: Fri, 26 Jul 2024 16:17:32 -0700 Subject: [PATCH] Use "no" instead of "disallow" in selector names To have a more consistent naming scheme between selector & action. https://github.com/microsoft/onnxruntime/pull/21182/files#r1692348150 --- .../selectors_actions/qdq_selector_action_transformer.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_selector_action_transformer.cc b/onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_selector_action_transformer.cc index 1223783a044a0..d81701fdf443b 100644 --- a/onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_selector_action_transformer.cc +++ b/onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_selector_action_transformer.cc @@ -60,17 +60,17 @@ void DropQDQNodesRules(SelectorActionRegistry& qdq_selector_action_registry) { // // And cannot eliminate the QDQ for MaxPool if the scale is not positive, as a negative // scale will change the ordering of the elements between quantized & de-quantized values. - std::unique_ptr selector_disallow_16bit = std::make_unique(false); + std::unique_ptr selector_no_16bit = std::make_unique(false); qdq_selector_action_registry.RegisterSelectorAndAction(drop_action_no_int16_name, {{"Resize", {}}}, - std::move(selector_disallow_16bit), + std::move(selector_no_16bit), std::move(drop_action_no_int16)); - std::unique_ptr selector_disallow_16bit_and_nonpositive_scale = + std::unique_ptr selector_no_16bit_and_positive_scale = std::make_unique(false, true, false); qdq_selector_action_registry.RegisterSelectorAndAction(drop_action_no_int16_and_positive_scale_name, {{"MaxPool", {12}}}, - std::move(selector_disallow_16bit_and_nonpositive_scale), + std::move(selector_no_16bit_and_positive_scale), std::move(drop_action_no_int16_and_positive_scale)); std::unique_ptr selector = std::make_unique(true);