From 9b27f009a8805a8e11922da34959d9a7bbf4949a Mon Sep 17 00:00:00 2001 From: vraspar Date: Fri, 2 Aug 2024 14:51:54 -0700 Subject: [PATCH] Add comments --- .../github/apple/assemble_apple_packaging_artifacts.sh | 5 ++++- tools/ci_build/github/apple/build_apple_framework.py | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/ci_build/github/apple/assemble_apple_packaging_artifacts.sh b/tools/ci_build/github/apple/assemble_apple_packaging_artifacts.sh index b8f5d0a869aa0..f96227a750346 100755 --- a/tools/ci_build/github/apple/assemble_apple_packaging_artifacts.sh +++ b/tools/ci_build/github/apple/assemble_apple_packaging_artifacts.sh @@ -23,7 +23,10 @@ ORT_POD_VERSION=${4:?${USAGE_TEXT}} POD_ARCHIVE_BASENAME="pod-archive-${POD_NAME}-${ORT_POD_VERSION}.zip" PODSPEC_BASENAME="${POD_NAME}.podspec" -# Check for directories starting with "macos" and create symlinks if necessary + +# Macos requires a different structure for the framework +# This will create the necessary symlinks for the macos framework before packaging +# Adding the symlinks here rather than in the build script ensures that symlinks are not lost for MACOS_DIR in "${BINARIES_STAGING_DIR}/${POD_NAME}/onnxruntime.xcframework/macos"*; do if [ -d "${MACOS_DIR}" ]; then echo "Creating symlinks for ${MACOS_DIR}" diff --git a/tools/ci_build/github/apple/build_apple_framework.py b/tools/ci_build/github/apple/build_apple_framework.py index f4982ffa5d7e2..7270bdd56523c 100644 --- a/tools/ci_build/github/apple/build_apple_framework.py +++ b/tools/ci_build/github/apple/build_apple_framework.py @@ -197,7 +197,6 @@ def _build_package(args): public_headers_path = os.path.join(os.path.dirname(framework_dir), "onnxruntime.framework", "Headers") # create the folder for xcframework and copy the LICENSE and framework_info.json file - # changes here xcframework_dir = os.path.join(build_dir, "framework_out") pathlib.Path(xcframework_dir).mkdir(parents=True, exist_ok=True) shutil.copy(os.path.join(REPO_DIR, "LICENSE"), xcframework_dir)