From 26cead405ce2d534c84604d2dcae1d3179623187 Mon Sep 17 00:00:00 2001 From: Scott McKay Date: Fri, 28 Jun 2024 09:01:58 +1000 Subject: [PATCH] Address PR comments --- .../core/providers/coreml/builders/impl/gemm_op_builder.cc | 2 +- onnxruntime/core/providers/coreml/builders/model_builder.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc b/onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc index bb5f829c4be4e..7338fc18fe779 100644 --- a/onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc +++ b/onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc @@ -113,7 +113,7 @@ Status GemmOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_builder, const N // ML Program MatMul supports N-D input, however we don't use the 'K' or 'N' values calculated below for it // so we don't need to update b0 or b1. } else { - // we only support 2D input for all other combination + // we only support 2D input for all other combinations b0 = b_shape[0]; b1 = b_shape[1]; } diff --git a/onnxruntime/core/providers/coreml/builders/model_builder.cc b/onnxruntime/core/providers/coreml/builders/model_builder.cc index abeae249b9a03..eec0fcce51dbc 100644 --- a/onnxruntime/core/providers/coreml/builders/model_builder.cc +++ b/onnxruntime/core/providers/coreml/builders/model_builder.cc @@ -906,7 +906,7 @@ Status ModelBuilder::SaveModel() { #if defined(COREML_ENABLE_MLPROGRAM) if (create_ml_program_) { - // we need to jump through some hurdles to get the model path the ML Program load wants. + // we need to jump through some hoops to get the model path the ML Program load wants. std::string tmp_model_path = model_output_path_ + "/tmp/model.mlmodel"; CreateEmptyFile(tmp_model_path);